On Thu, Mar 14, 2024 at 3:09 AM Martin Jansa <martin.ja...@gmail.com> wrote:
>
> * it's enabled for patches in oe-core for very long time and I was using
>   it for many other layers as well, so most layers should be in good
>   shape
>
> * it's also possible to disable it for individual layer as shown
>   by oe-core in:
>   
> https://git.openembedded.org/openembedded-core/commit/meta/classes-global/insane.bbclass?h=scarthgap&id=61a881fdbe8b5a21c6276b8a5d06cc30486b1eb3

Most people have heard my opinions on tracking status
within files themselves (versus the revision control
system), but that's not the point of my reply (for once!)

Even with the QA error only enabled in oe-core at the
moment, it is effectively enabled / enforced in all layers
... since if someone is building a product and enables
the QA error .. all layers are going to have to comply
even if they don't agree (since removing it from
someone's  QA checklist in a layer would probably
fail yocto compat standards).

The summary of my rambling is: that I lost the debate
when the check was created and became an error
in OEcore.  So surprisingly, it doesn't really matter to
me, but I lean towards doing it post release as well.

Bruce


>
> Signed-off-by: Martin Jansa <martin.ja...@gmail.com>
> ---
>  meta/classes-global/insane.bbclass | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta/classes-global/insane.bbclass 
> b/meta/classes-global/insane.bbclass
> index e963001d09..9350bfa106 100644
> --- a/meta/classes-global/insane.bbclass
> +++ b/meta/classes-global/insane.bbclass
> @@ -45,11 +45,10 @@ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch 
> pkgconfig la \
>              already-stripped installed-vs-shipped ldflags compile-host-path \
>              install-host-path pn-overrides unknown-configure-option \
>              useless-rpaths rpaths staticdev empty-dirs \
> -            patch-fuzz \
> +            patch-fuzz patch-status \
>              "
>  # Add usrmerge QA check based on distro feature
>  ERROR_QA:append = "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', ' 
> usrmerge', '', d)}"
> -ERROR_QA:append:layer-core = " patch-status"
>  WARN_QA:append:layer-core = " missing-metadata missing-maintainer"
>
>  FAKEROOT_QA = "host-user-contaminated"
> --
> 2.44.0
>
>
> 
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#197114): 
https://lists.openembedded.org/g/openembedded-core/message/197114
Mute This Topic: https://lists.openembedded.org/mt/104922136/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to