Hi Iskander,

linux-firmware storing all firmwware, can you add "Intel AC 9260" in the commit title so we know what we're talking about :) ?

On 4/23/24 14:02, Iskander Amara wrote:
In order to use the Intel bluetooth 9260 firmware, we need to

"""
In order to use Bluetooth on Intel 9260,
"""

is probably a better wording here?

select linux-firmware-ibt-misc package that brings a lot of fi-
mwares that are, in most cases, irrelevant for the used hardware.
 > This adds a new package linux-firmware-ibt-9260 that only inclu-
des Intel 9260 bluetooth chip's firmware.


Would be nice to give the commit in linux-firmware that added the firmware for the Bluetooth part of the Intel AC 9260 to justify this change, c.f.:

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?h=20220610&id=97339b3a1d3bf3e4c40d679896a27a25fa83765f

Reported-by: Quentin Schulz <quentin.sch...@theobroma-systems.com>
Signed-off-by: Iskander Amara <iskander.am...@theobroma-systems.com>
---
  meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb 
b/meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb
index ff79bb9b33..dfa387ec11 100644
--- a/meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb
+++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb
@@ -344,6 +344,7 @@ PACKAGES =+ "${PN}-amphion-vpu-license ${PN}-amphion-vpu \
               ${PN}-ibt-11-5 ${PN}-ibt-12-16 ${PN}-ibt-hw-37-7 
${PN}-ibt-hw-37-8 \
               ${PN}-ibt-17 \
               ${PN}-ibt-20 \
+             ${PN}-ibt-9260 \
               ${PN}-ibt-misc \
               ${PN}-i915-license ${PN}-i915 \
               ${PN}-ice-license ${PN}-ice \
@@ -1273,6 +1274,7 @@ LICENSE:${PN}-ibt-11-5    = "Firmware-ibt_firmware"
  LICENSE:${PN}-ibt-12-16   = "Firmware-ibt_firmware"
  LICENSE:${PN}-ibt-17 = "Firmware-ibt_firmware"
  LICENSE:${PN}-ibt-20 = "Firmware-ibt_firmware"
+LICENSE:${PN}-ibt-9260    = "Firmware-ibt_firmware"

I think we should rather name this ${PN}-ibt-18 to match what seems to be the naming scheme for those packages.

If you do, please order everything alphabetically (so above ibt-20 for example).

Looking good otherwise.

Cheers,
Quentin
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#198625): 
https://lists.openembedded.org/g/openembedded-core/message/198625
Mute This Topic: https://lists.openembedded.org/mt/105687932/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to