On Tue, May 7, 2024 at 12:56 PM Alexander Kanavin <alex.kana...@gmail.com> wrote: > > On Tue, 7 May 2024 at 18:13, Khem Raj <raj.k...@gmail.com> wrote: > > Firstly I am inclined towards removing it if we can, since I think it > > should be > > packages to decide to use it, then they can maintain it better from testing > > POV, > > However, there is something > > to consider w.r.t. to this option. This does help in optimizing loading DSOs > > by reducing the number of PLTs and improves loading time for DSOs which > > might > > be quite meaningful for embedded devices that we target. However, we only > > enable hidden visibility only for inlines so it won't be full benefits but > > we do > > have better default compatibility. > > > > Since we have had this option for a long time and it still seems > > relevant, I would > > think it would make sense to do some benchmarking on a sizeable C++ program > > perhaps chromium or webkit, and see the difference in DSOs sizes with > > and without > > this option and also benchmark the loading time of the resulting > > chromium package. > > > > maybe we will find that the gains are not as significant, in that case > > we might drop > > it from defaults. > > I digged deeper and this is where I think it originated: > https://git.openembedded.org/openembedded/commit/?id=ddd6d1fd26416a3766d754eeda4237a680a65520 > > Ah the simpler times of oe-classic, when one could bundle four > unrelated changes into one commit and explain none of them. > > Benchmarking I have no time for right now, just wanted to point out > that adding the flag was never justified in commit log. Can you > experiment with webkit? >
Yes, I have added it to my backlog. > Alex
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#199106): https://lists.openembedded.org/g/openembedded-core/message/199106 Mute This Topic: https://lists.openembedded.org/mt/105955497/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
