> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> c...@lists.openembedded.org> On Behalf Of Alexander Kanavin
> Sent: den 27 maj 2024 18:46
> To: 이재규 <jkbestfam...@gmail.com>
> Cc: jaekyu....@lge.com; openembedded-core@lists.openembedded.org
> Subject: Re: [PATCH] [OE-core][scarthgap] rust: remove unnecessary git
> signature
>
> On Mon, 27 May 2024 at 18:41, 이재규 <jkbestfam...@gmail.com> wrote:
> >
> > Thank you for reply.
> >
> > I don't think we need to remove it specifically for this patch.
> > If possible, I will update patch to remove it from all patches. Do you
> > agree that information ( git version information) is unnecessary?
>
> It might be unnecessary, but I do not think there is a need to remove
> it. If 'git format-patch' adds that when it writes a patch file to
> disk, then we shouldn't fight with that: people will keep sending
> patch files that have it.
>
> Alex
For the record, patches generated/updated by devtool will be created with
`git format-patch --no-signature --no-numbered ...` and thus lack the git
version at the end.
Personally, I have the following in my .gitconfig to avoid having
`git format-name ...` generate the signature:
[format]
signature =
But as Alex says, some will generate patches with the Git signature, and
some will generate them without it. So unless someone adds some check for
their non-existence, e.g., to patchcheck, they will come and go depending
on who generates the patches.
//Peter
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#199949):
https://lists.openembedded.org/g/openembedded-core/message/199949
Mute This Topic: https://lists.openembedded.org/mt/106323318/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
