I don't think this is correct. What if someone wants to enable these
features but not enable webrtc? Before this change it would be
possible, and now it isn't.

If someone wants webrtc, they should add these two to their
packageconfig as well; perhaps there could be a comment in the recipe.

Alex

On Sun, 9 Jun 2024 at 23:13, Markus Volk via lists.openembedded.org
<f_l_k=t-online...@lists.openembedded.org> wrote:
>
> - connect them to webrtc
>
> This avoids:
>  ../gst-plugins-bad-1.24.3/ext/sctp/meson.build:8:33: ERROR: Feature sctp 
> cannot be disabled: webrtc option is enabled
>  ../gst-plugins-bad-1.24.3/ext/srtp/meson.build:10:33: ERROR: Feature srtp 
> cannot be disabled: webrtc option is enabled
>
> Signed-off-by: Markus Volk <f_...@t-online.de>
> ---
>  .../gstreamer/gstreamer1.0-plugins-bad_1.24.3.bb              | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git 
> a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.24.3.bb 
> b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.24.3.bb
> index dbd504e87d..a990faf3bb 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.24.3.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.24.3.bb
> @@ -74,11 +74,9 @@ PACKAGECONFIG[resindvd]        = 
> "-Dresindvd=enabled,-Dresindvd=disabled,libdvdr
>  PACKAGECONFIG[rsvg]            = "-Drsvg=enabled,-Drsvg=disabled,librsvg"
>  PACKAGECONFIG[rtmp]            = "-Drtmp=enabled,-Drtmp=disabled,rtmpdump"
>  PACKAGECONFIG[sbc]             = "-Dsbc=enabled,-Dsbc=disabled,sbc"
> -PACKAGECONFIG[sctp]            = "-Dsctp=enabled,-Dsctp=disabled"
>  PACKAGECONFIG[smoothstreaming] = 
> "-Dsmoothstreaming=enabled,-Dsmoothstreaming=disabled,libxml2"
>  PACKAGECONFIG[sndfile]         = 
> "-Dsndfile=enabled,-Dsndfile=disabled,libsndfile1"
>  PACKAGECONFIG[srt]             = "-Dsrt=enabled,-Dsrt=disabled,srt"
> -PACKAGECONFIG[srtp]            = "-Dsrtp=enabled,-Dsrtp=disabled,libsrtp"
>  PACKAGECONFIG[tinyalsa]        = 
> "-Dtinyalsa=enabled,-Dtinyalsa=disabled,tinyalsa"
>  PACKAGECONFIG[ttml]            = "-Dttml=enabled,-Dttml=disabled,libxml2 
> pango cairo"
>  PACKAGECONFIG[uvch264]         = 
> "-Duvch264=enabled,-Duvch264=disabled,libusb1 libgudev"
> @@ -91,7 +89,7 @@ PACKAGECONFIG[voamrwbenc]      = 
> "-Dvoamrwbenc=enabled,-Dvoamrwbenc=disabled,vo-
>  PACKAGECONFIG[vulkan]          = 
> "-Dvulkan=enabled,-Dvulkan=disabled,vulkan-loader shaderc-native"
>  PACKAGECONFIG[wayland]         = 
> "-Dwayland=enabled,-Dwayland=disabled,wayland-native wayland 
> wayland-protocols libdrm"
>  PACKAGECONFIG[webp]            = "-Dwebp=enabled,-Dwebp=disabled,libwebp"
> -PACKAGECONFIG[webrtc]          = "-Dwebrtc=enabled,-Dwebrtc=disabled,libnice"
> +PACKAGECONFIG[webrtc]          = "-Dwebrtc=enabled -Dsctp=enabled 
> -Dsrtp=enabled,-Dwebrtc=disabled -Dsctp=disabled -Dsrtp=disabled,libnice 
> libsrtp"
>  PACKAGECONFIG[webrtcdsp]       = 
> "-Dwebrtcdsp=enabled,-Dwebrtcdsp=disabled,webrtc-audio-processing-1"
>  PACKAGECONFIG[zbar]            = "-Dzbar=enabled,-Dzbar=disabled,zbar"
>  PACKAGECONFIG[x11]             = "-Dx11=enabled,-Dx11=disabled,libxcb 
> libxkbcommon"
> --
> 2.45.1
>
>
> 
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#200467): 
https://lists.openembedded.org/g/openembedded-core/message/200467
Mute This Topic: https://lists.openembedded.org/mt/106582373/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to