On 6/20/24 00:45, Ross Burton wrote:
CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know 
the content is safe.

On 19 Jun 2024, at 10:17, Yu, Mingli via lists.openembedded.org 
<mingli.yu=eng.windriver....@lists.openembedded.org> wrote:
+The nfs tests will be put into XPASS/XFAIL category as it defined in
+XFAIL_TESTS target, group all the test only in TESTS target as we prefer
+use PASS/FAIL/SKIP to indicate the result.

XPASS/XFAIL is fine, we don’t need to change the tests.

Okay, I will move back these two cases to XPASS/XFAIL.


diff --git 
a/meta/recipes-support/attr/acl/0001-test-nfs-nfsacl.test-Correct-the-check-item.patch
 
b/meta/recipes-support/attr/acl/0001-test-nfs-nfsacl.test-Correct-the-check-item.patch
new file mode 100644
index 0000000000..f990ca4a31
--- /dev/null
+++ 
b/meta/recipes-support/attr/acl/0001-test-nfs-nfsacl.test-Correct-the-check-item.patch
@@ -0,0 +1,51 @@
+From dfc6328f02821f9c6703f764ec6f53cf81daaab6 Mon Sep 17 00:00:00 2001
+From: Mingli Yu <mingli...@windriver.com>
+Date: Mon, 17 Jun 2024 11:00:43 +0800
+Subject: [PATCH] test/nfs/nfsacl.test: Correct the check item
+
+The date such as "Jun 13" should take 2 columns, so the expected check
+item "test/sub2" should the column 9.
+ # ls test/sub2 -dl
+drwxr-xr-x 2 root root 4096 Jun 13 06:01 test/sub2
+
+Upstream-Status: Submitted 
[https://lists.nongnu.org/archive/html/acl-devel/2024-06/msg00002.html]

What this why the test is an XFAIL?  In which case the previous patch should 
make it clear that we’re not removing XFAIL because we don’t like it, but 
because the tests are now fixed.

That's okay, will move back these two cases to XPASS/XFAIL.


diff --git a/meta/recipes-support/attr/acl/run-ptest 
b/meta/recipes-support/attr/acl/run-ptest
index 3af75c84fe..7d88cc8484 100644
--- a/meta/recipes-support/attr/acl/run-ptest
+++ b/meta/recipes-support/attr/acl/run-ptest
@@ -6,6 +6,7 @@

mkdir -p /tmp/acl-ptest/test
cp test/test.* /tmp/acl-ptest/test
+export EXPORT_PATH="/tmp/acl-ptest/test”

Whilst you’re here, this looks fragile.  Can you use mktemp -d to make a fresh 
directory for each run?

The directory which used to include not only the test file, but also the file used for test such as test.passwd and test.group, and this directory is preconfigured during build as
https://git.openembedded.org/openembedded-core/tree/meta/recipes-support/attr/acl/0001-tests-do-not-hardcode-the-build-path-into-a-helper-l.patch.

Thanks,


Ross

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#201065): 
https://lists.openembedded.org/g/openembedded-core/message/201065
Mute This Topic: https://lists.openembedded.org/mt/106757200/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to