> -----Original Message----- > From: openembedded-core@lists.openembedded.org > <openembedded-core@lists.openembedded.org> On Behalf Of Richard Purdie > Sent: den 28 augusti 2024 18:15 > To: openembedded-core@lists.openembedded.org > Subject: [OE-core] [PATCH] insane: Drop oe.qa.add_message usage > > Drop the oe.qa.add_message() usage in favour of oe.qa.handle_error() which has > code allowing it to be optimised with contains usage. > > The patch also drops unused return values which we stopped using a while ago > and drops the now unneeded function parameters, generally leading to cleaner > code. > > The code should be functionally equivalent.
There is at least one difference. We have the following in our distro: WARN_QA:remove = "virtual-slash" ERROR_QA:remove = "virtual-slash" since we do not build any package feeds and thus this QA error is not a problem for us. After the change from add_message() to handle_error(), I now get a lot of: NOTE: /path/to/recipe_1.2.3.bb: QA Issue: RDEPENDS is set to virtual/foobar but the substring 'virtual/' holds no meaning in this context. It only works for build time dependencies, not runtime ones. It is suggested to use 'VIRTUAL-RUNTIME_' variables instead. [virtual-slash] during recipe parsing, which defeats the purpose of turning of the QA error. Now, we can of course fix our recipes to avoid the use of runtime dependencies on virtual/. I just wanted to point out that there is a difference in functionality, and one that is hard to do anything about in layers on top of OE-Core. > > Signed-off-by: Richard Purdie <richard.pur...@linuxfoundation.org> > --- > meta/classes-global/insane.bbclass | 219 +++++++++++------------------ > meta/lib/oe/qa.py | 6 - > 2 files changed, 84 insertions(+), 141 deletions(-) //Peter
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#204045): https://lists.openembedded.org/g/openembedded-core/message/204045 Mute This Topic: https://lists.openembedded.org/mt/108145107/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
