Hi Ross, On 9/24/24 1:35 PM, Ross Burton via lists.openembedded.org wrote:
On 20 Sep 2024, at 19:41, Jon Mason via lists.openembedded.org <jdmason=kudzu...@lists.openembedded.org> wrote: --- a/scripts/lib/wic/canned-wks/mkefidisk.wks +++ b/scripts/lib/wic/canned-wks/mkefidisk.wks @@ -8,4 +8,4 @@ part / --source rootfs --ondisk sda --fstype=ext4 --label platform --align 1024 part swap --ondisk sda --size 44 --label swap1 --fstype=swap -bootloader --ptable gpt --timeout=5 --append="rootfstype=ext4 console=ttyS0,115200 console=tty0" +bootloader --ptable gpt --timeout=5 --append="rootfstype=ext4 console=${KERNEL_CONSOLE} console=tty0”My understanding was the .wks files had to be .wks.in for variable expansion to happen. Can you confirm that this is actually just an idiom and the expansions happen always?
meta-rockchip also does variable expansion for wic and only has rockchip.wks (and not wks.in), so that's one more that works with this (though if that is a missed corner case that we aren't supposed to support is another question).
Cheers, Quentin
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#205106): https://lists.openembedded.org/g/openembedded-core/message/205106 Mute This Topic: https://lists.openembedded.org/mt/108564893/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
