Okay, nobody forced you to reply. Your review was terrible. If it is not ok you could simply say that for a reason, but there were thousands of better way to say that.
On Fri, 22 Nov 2024, 15:40 Martin Jansa, <martin.ja...@gmail.com> wrote: > This isn't a fix, it's just very bad work around, see: > > https://git.openembedded.org/openembedded-core/tree/meta/classes-recipe/cargo-update-recipe-crates.bbclass > which you can use to avoid needing the network access during do_compile. > > On Fri, Nov 22, 2024 at 2:32 PM Kareem Ibrahim via > lists.openembedded.org > <karem.ibrahim46=gmail....@lists.openembedded.org> wrote: > > > > - This change was intended to abstract user from having to set compile > network flag to get remote crates > > - as network access was disabled by default in kirkstone version > > - I faced an do_compile error with bitbaking Qualcomm qcrosvm under > yocto kirkstone with message "Could not resolve host: github.com" > > - And after some hours of debugging I noticed that cargo inherited by > recipe needs remote crates during do_compile of the cargo.bbclass > > - It was fixed by adding line do_compile[network] = "1" to the recipe > > - So I found it more convenient, since cargo build usually need network > access, to abstract users from these details of cargo.bbclass do_compile > > > > Signed-off-by: Kareem Ibrahim <karem.ibrahi...@gmail.com> > > --- > > meta/classes/cargo-online.bbclass | 7 +++++++ > > 1 file changed, 7 insertions(+) > > create mode 100644 meta/classes/cargo-online.bbclass > > > > diff --git a/meta/classes/cargo-online.bbclass > b/meta/classes/cargo-online.bbclass > > new file mode 100644 > > index 0000000000..175c94e09d > > --- /dev/null > > +++ b/meta/classes/cargo-online.bbclass > > @@ -0,0 +1,7 @@ > > +# This bbclass is added to abstract recipes writers from > > +# having to set do_compile network flag to 1 > > +# if his cargo package need external remote crates > > +# as network access was disabled by default since kirkstone version > > + > > +inherit cargo > > +do_compile[network] = "1" > > \ No newline at end of file > > -- > > 2.25.1 > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#207624): https://lists.openembedded.org/g/openembedded-core/message/207624 Mute This Topic: https://lists.openembedded.org/mt/109721978/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
