On Tue, 2025-01-21 at 09:12 +0100, Jan Strater-Büddefeld via lists.openembedded.org wrote: > Fixes [YOCTO #15579] > > This commit removes the LD_LIBRARY_PATH wrapper around `cargo`. > Setting the LD_LIBRARY_PATH causes many problems. > Some build scripts will not run because the build scripts execute > binaries from the host system that are not compatible with the target > libraries. > Even a simple `cargo help build` can fail because it uses `less` > internally, which should not be linked against the target libraries. > > There might be cases where the LD_LIBRARY_PATH is needed for some hosts, > like the case described in 388e7cac9f90e79ce8c3c1683d8ee0f4df1bc907 > but one can always set LD_LIBRARY_PATH manually if needed. > > A current working workaround without this commit would be always using > `cargo.real` instead of `cargo`, which can lead to confusion. > > Signed-off-by: Jan Strater-Büddefeld <[email protected]> > --- > meta/recipes-devtools/rust/cargo_1.81.0.bb | 8 -------- > 1 file changed, 8 deletions(-)
That wrapper was added for a reason. Is that reason still valid and how do you plan to mitigate against the issues it was originally added for? The commit message needs to mention this. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#210072): https://lists.openembedded.org/g/openembedded-core/message/210072 Mute This Topic: https://lists.openembedded.org/mt/110730216/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
