Hi Adam,
On 12/15/25 11:20 AM, Adam Duskett via lists.openembedded.org wrote:
- Add a BUGTRACKER link
- Move SRCREV to below SRC_URI
- Use gitsm instead of multiple git entries in the SRC_URI
- Remove SRCEV_FORMAT as it is not needed.
- Add a tag to the SRC_URI
- Add a UPSTREAM_CHECK_GITTAGREGEX field
- Use `PTEST_ENABLED 1` instead of `DISTRO_FEATURES ptest`
- Change "Submitted" in 0001-Remove-whitespace-in-operator.patch
to "Backport" with the appropraite link to the relevant commit hash.
- Clean up run-ptest.
- Add libtoml11 to maintainers.inc and ptest-packagelist.inc
Usually when you need to have a list of things you have done in a
commit, it means each item should be its own commit.
OE-Core/BitBake/Yocto is a bit more relaxed than other projects on that
rule but I find it a good thing to do in general.
Looks good to me, so:
Reviewed-by: Quentin Schulz <[email protected]>
Small note on UPSTREAM_CHECK_GITTAGREGEX, isn't the default (
"(?P<pver>([0-9][\.|_]?)+)" ) sufficient? Regex101 seems to be matching
4.4.0 out of v4.4.0.
Also if you're changing it from the default, maybe add the v as first
char since this seems to be the naming scheme for the tags in that repo?
UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)"
[...]
diff --git a/meta/recipes-devtools/libtoml11/files/run-ptest
b/meta/recipes-devtools/libtoml11/files/run-ptest
index 9bc480aa7f..22d6f7e0e1 100755
--- a/meta/recipes-devtools/libtoml11/files/run-ptest
+++ b/meta/recipes-devtools/libtoml11/files/run-ptest
@@ -1,12 +1,13 @@
-#!/bin/sh
+#!/usr/bin/env sh
cd tests
-for atest in test_* ; do
- rm -rf tests.log
- ./${atest} > tests.log 2>&1
- if [ $? = 0 ] ; then
- echo "PASS: ${atest}"
+
+rm -rf tests.log
+
+for i in test_* ; do
+ if ./"${i}" >> tests.log 2>&1; then
+ echo "PASS: ${i}"
else
- echo "FAIL: ${atest}"
+ echo "FAIL: ${i}"
Renaming atest to i incurs unnecessary noise in the diff.
fi
done
diff --git a/meta/recipes-devtools/libtoml11/libtoml11_4.4.0.bb
b/meta/recipes-devtools/libtoml11/libtoml11_4.4.0.bb
index 38786b79ed..c3b00511ae 100644
--- a/meta/recipes-devtools/libtoml11/libtoml11_4.4.0.bb
+++ b/meta/recipes-devtools/libtoml11/libtoml11_4.4.0.bb
@@ -1,9 +1,10 @@
SUMMARY = "TOML for Modern C++"
-DESCRIPTION = "toml11 is a feature-rich TOML language library for \
- C++11/14/17/20."
-
+DESCRIPTION = "\
+ toml11 is a feature-rich TOML language library for \
+ C++11/14/17/20. \
+"
I believe this change means we have even more useless whitespaces in the
description.
Cheers,
Quentin
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#227726):
https://lists.openembedded.org/g/openembedded-core/message/227726
Mute This Topic: https://lists.openembedded.org/mt/116789991/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
