On Mon, Mar 16, 2026 at 5:03 PM Michal Sieron via lists.openembedded.org <[email protected]> wrote:
> While in this case `CORE_IMAGE_EXTRA_INSTALL::pn-* +=` wouldn't result > in any unwanted override, there is no guarantee there won't be a change, > which would be hidden by this override. To avoid any surprises in the > future let's use `:append:pn-* =` syntax here. > > Signed-off-by: Michal Sieron <[email protected]> > --- > meta/conf/distro/include/no-gplv3.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/conf/distro/include/no-gplv3.inc > b/meta/conf/distro/include/no-gplv3.inc > index 705e05319a..2034204035 100644 > --- a/meta/conf/distro/include/no-gplv3.inc > +++ b/meta/conf/distro/include/no-gplv3.inc > @@ -18,9 +18,9 @@ PACKAGECONFIG:remove:pn-bluez5 = "readline" > # dnf pulls in gpg which is gpl3; it also pulls in python3-rpm which > pulls in rpm-build which pulls in bash > # so install rpm but not dnf > IMAGE_FEATURES:remove:pn-core-image-weston = "package-management" > -CORE_IMAGE_EXTRA_INSTALL:pn-core-image-weston += "rpm" > +CORE_IMAGE_EXTRA_INSTALL:append:pn-core-image-weston = " rpm" > IMAGE_FEATURES:remove:pn-core-image-full-cmdline = "package-management" > -CORE_IMAGE_EXTRA_INSTALL:pn-core-image-full-cmdline += "rpm" > +CORE_IMAGE_EXTRA_INSTALL:append:pn-core-image-full-cmdline = " rpm" > while this patch is ok, I wonder if hardcoding rpm is the right thing here as it might be not right for distros not using rpm backend e.g. ipk or deb backends instead. > > # matchbox-terminal depends on vte, which is gpl3 > CORE_IMAGE_BASE_INSTALL:remove:pn-core-image-weston = "matchbox-terminal" > > -- > 2.53.0 > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#233289): https://lists.openembedded.org/g/openembedded-core/message/233289 Mute This Topic: https://lists.openembedded.org/mt/118356437/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
