On Mon 2026-04-13 @ 11:32:16 AM, Antonin Godard wrote: > Hi, > > On Thu Mar 26, 2026 at 1:11 AM CET, Trevor Woerner via lists.openembedded.org > wrote: > > The previous implementation had the following limitations: > > - required the variable WIC_SECTOR_SIZE either be defined in a > > configuration file or be defined in a --vars file > > - this means that every invocation of "wic ls", "wic cp", or "wic rm" > > needed this variable defined (config or --vars) > > - required the user to create separate *wks files for every sector size > > they wanted to use > > - required the user to specify the --mkfs-extraopts by hand to specify the > > correct sector size: e.g. > > bootloader --ptable gpt > > part --fstype vfat --label emptyfat --mkfs-extraopts "-S 4096" > > part --fstype ext4 --source rootfs --label rofs-a --mkfs-extraopts "-b > > 4096" > > part --fstype ext4 --source rootfs --use-uuid --mkfs-extraopts "-b 4096" > > - it would not be possible to generate images with different sector > > sizes in the same build since the configuration and *wks files would > > need to change and the build re-run for each size > > > > The new implementation handles the sector-size via a CLI argument, while > > preserving the previously implemented variable definitions: > > - the sector-size may now be provided on the cmdline to the "wic ls", > > "wic cp", "wic rm", and "wic create" commands: default = 512 > > - this means the configuration and/or --vars file does not need to be > > changed in order to perform those operations on images with different > > sector sizes > > - support is provided implicitly for mkdosfs and ext[234] partitions > > - the user no longer needs to know and supply the sector-size magic in > > --mkfs-extraopts (thereby clobbering the other defaults) > > > > As before, if the --sector-size command-line argument is not given, > > allow the sector-size to be provided via the WIC_SECTOR_SIZE bitbake > > variable. The user is warned that this behavior is deprecated. If both > > are given, warn the user that the cmdline argument takes precedence. > > > > AI-Generated: codex/gpt-5.1-codex-max > > Signed-off-by: Trevor Woerner <[email protected]> > > > > - restore environ test case, as it is still supported (but obsolete) > > - revised commit message above > > > > Signed-off-by: Mark Hatle <[email protected]> > > --- > > changes in v8: > > - Mark Hatle stepped in to help provide advice and updates > > - add back the code and test to support/allow users to specify a > > sector-size in --mkfs-extraopts, this gives the user 3 places in which > > the sector-size can be specified: > > 1. cmdline > > 2. --mkfs-extraopts in *.wks files > > 3. WIC_SECTOR_SIZE bitbake variable/--vars file > > I've written a migration note here (sent on the docs list): > https://lore.kernel.org/r/[email protected] > > Could you confirm that this is the right approach?
Yes, that should work. I was envisioning people writing their own classes to call wic with the appropriate sector-size setting, but WIC_CREATE_EXTRA_ARGS should work fine as well. Thanks!
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#235115): https://lists.openembedded.org/g/openembedded-core/message/235115 Mute This Topic: https://lists.openembedded.org/mt/118511212/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
