On Mon, 2026-05-04 at 17:16 -0700, Quan.Sun via lists.openembedded.org wrote:
> From: Quan Sun <[email protected]>
> 
> Signed-off-by: Quan Sun <[email protected]>

The changelog should mention any key changes.

> @@ -26,8 +26,6 @@ do_install:append() {
>      rm -rf ${D}${datadir}/icons/
>      rm -rf ${D}${includedir}/qemu-plugin.h
>  
> -    # Install qmp.py to be used with testimage
> -    install -d ${D}${libdir}/qemu-python/qmp/
> -    install -D ${S}/python/qemu/qmp/* ${D}${libdir}/qemu-python/qmp/
> +    # The qemu.qmp library from the main QEMU repository has now been 
> removed.
>  }

This looks like a key change that should be mentioned!

Unfortunately, as the code says, testimage uses qmp. We therefore need
to find a new way to provide qmp for testimage. We can't simply delete
it and the comment you've left isn't useful either.

https://github.com/qemu/qemu/commit/e1e49b35b3c3cf6b7c68b6b1df18a477ac3183e5

mentioned we should be using:

https://gitlab.com/qemu-project/python-qemu-qmp/


> @@ -26,5 +26,5 @@ index 82cace1..83bbda9 100755
>  -fi
>  +meson=`which meson`
>   
> - # Conditionally ensure Sphinx is installed.
> - 
> + # On Haiku, meson might show up in a "non-packaged" subfolder instead, see
> + # 
> https://github.com/haiku/haiku/blob/r1beta5/docs/user/storage/storageintro.dox
> diff --git 
> a/meta/recipes-devtools/qemu/qemu/0010-meson-fix-subproject-include-paths-for-standalone-bu.patch
>  
> b/meta/recipes-devtools/qemu/qemu/0010-meson-fix-subproject-include-paths-for-standalone-bu.patch
> new file mode 100644
> index 0000000000..b7d31f0ed7
> --- /dev/null
> +++ 
> b/meta/recipes-devtools/qemu/qemu/0010-meson-fix-subproject-include-paths-for-standalone-bu.patch
> @@ -0,0 +1,52 @@
> +From f013e84d382bc1bd7d49206bdf47c689b0c6fbb5 Mon Sep 17 00:00:00 2001
> +From: Quan Sun <[email protected]>
> +Date: Fri, 1 May 2026 13:53:24 -0700
> +Subject: [PATCH] meson: fix subproject include paths for standalone builds
> +
> +Upstream-Status: Pending

Why Pending? Do we need to dicuss this issue with upstream?

Cheers,

Richard


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#236464): 
https://lists.openembedded.org/g/openembedded-core/message/236464
Mute This Topic: https://lists.openembedded.org/mt/119154124/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to