> -----Original Message----- > From: [email protected] <openembedded- > [email protected]> On Behalf Of Alexander Kanavin via > lists.openembedded.org > Sent: Wednesday, 13 May 2026 14:32 > To: Daniel Turull <[email protected]> > Cc: [email protected] > Subject: Re: [OE-core] [PATCH v2] devtool: upgrade: extract changelog between > versions > > On Wed, 13 May 2026 at 14:20, <[email protected]> wrote: > > + def _check_changelog(self, recipe, oldrecipefile): > > + """Compare extracted changelog against reference data if > > available.""" > > + changelog_ref = oldrecipefile + '.changelog' > > + if not os.path.exists(changelog_ref): > > + return > > I think these last two lines should be removed, so that the changelog check is > enforced. Otherwise it's way too easy to regress the test, e.g. by replacing > the > test recipes, or adding new recipes without associated changelogs, or with > changelog files that are slightly misnamed. >
Ok. I'll drop them and send a v3 with it. Thanks for the quick feedback Alex. > Other than this, lgtm, thanks! > > Alex
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#236969): https://lists.openembedded.org/g/openembedded-core/message/236969 Mute This Topic: https://lists.openembedded.org/mt/119295883/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
