On Mon, 2012-10-08 at 11:35 +0300, Laurentiu Palcu wrote: > > On 10/06/2012 09:13 PM, Khem Raj wrote: > > On Sat, Oct 6, 2012 at 9:21 AM, Martin Jansa <martin.ja...@gmail.com> wrote: > >> > >>> +# IMPORTANT: This piece needs to be removed once the root cause is fixed! > >>> +do_install_append() { > >>> + create_wrapper ${D}/${bindir}/qemu-mips \ > >>> + QEMU_RESERVED_VA=0x0 > >>> +} > >>> +# END of qemu-mips workaround > >> > >> What about checking if mips is in QEMU_TARGETS before doing this? > >> > > > > or simply for check for existence of qemu-mips before creating the wrapper > > > >> Right now this breaks all distros without mips in QEMU_TARGETS. > Sorry, I totally missed this. :| What about adding a simple check in the > create_wrapper script itself? We create the wrapper only if the target > binary exists. It sounds better this way and the user does not > necessarily have to remember to check for the binary existence before > creating the wrapper. > > I'll prepare a patch.
In general I think we expect the target to exist. qemu is a little special since the user can configure it different ways. I therefore see qemu as being the exception in this case rather than the rule and think the default behaviour for create_wrapper should be to fail if it doesn't exist as there is likely some other issue. Cheers. Richard _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core