The bb.fatal() is defined as: def fatal(*args): logger.critical(''.join(args)) sys.exit(1)
So anything after bb.fatal() in the same code block doesn't have any effect, e.g.: bb.fatal("%s_%s: %s" % (var, pkg, e)) raise e The "raise e" should be removed. I searched all the files which use bb.fatal(), only the following 3 classes have this issues: insane.bbclass package.bbclass package_rpm.bbclass [YOCTO #4461] Signed-off-by: Robert Yang <liezhi.y...@windriver.com> --- meta/classes/insane.bbclass | 1 - meta/classes/package.bbclass | 1 - meta/classes/package_rpm.bbclass | 2 -- 3 files changed, 4 deletions(-) diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 336beaa..6b696b1 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -715,7 +715,6 @@ def package_qa_check_deps(pkg, pkgdest, skip, d): rvar = bb.utils.explode_dep_versions2(localdata.getVar(var, True) or "") except ValueError as e: bb.fatal("%s_%s: %s" % (var, pkg, e)) - raise e for dep in rvar: for v in rvar[dep]: if v and not v.startswith(('< ', '= ', '> ', '<= ', '>=')): diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass index 1a8da40..a31e6bd 100644 --- a/meta/classes/package.bbclass +++ b/meta/classes/package.bbclass @@ -375,7 +375,6 @@ python package_get_auto_pr() { auto_pr=prserv_get_pr_auto(d) except Exception as e: bb.fatal("Can NOT get PRAUTO, exception %s" % str(e)) - return if auto_pr is None: if d.getVar('PRSERV_LOCKDOWN', True): bb.fatal("Can NOT get PRAUTO from lockdown exported file") diff --git a/meta/classes/package_rpm.bbclass b/meta/classes/package_rpm.bbclass index 3a29976..edd90da 100644 --- a/meta/classes/package_rpm.bbclass +++ b/meta/classes/package_rpm.bbclass @@ -674,12 +674,10 @@ python write_specfile () { pkgdest = d.getVar('PKGDEST', True) if not pkgdest: bb.fatal("No PKGDEST") - return outspecfile = d.getVar('OUTSPECFILE', True) if not outspecfile: bb.fatal("No OUTSPECFILE") - return # Construct the SPEC file... srcname = strip_multilib(d.getVar('PN', True), d) -- 1.7.10.4 _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core