On Jun 28, 2013, at 12:28 PM, Mark Hatle <mark.ha...@windriver.com> wrote:
> On 6/28/13 2:23 PM, Saul Wold wrote: >> This will allow for SECURITY_CFLAGS and SECURITY_LDFLAGS to be >> defined in the security_flags.inc and override the empty default. >> >> Signed-off-by: Saul Wold <s...@linux.intel.com> >> --- >> meta/conf/bitbake.conf | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf >> index 62a3936..72e1a78 100644 >> --- a/meta/conf/bitbake.conf >> +++ b/meta/conf/bitbake.conf >> @@ -493,7 +493,8 @@ export TARGET_CPPFLAGS = "" >> >> export BUILD_CFLAGS = "${BUILD_CPPFLAGS} ${BUILD_OPTIMIZATION}" >> BUILDSDK_CFLAGS = "${BUILDSDK_CPPFLAGS} ${BUILD_OPTIMIZATION}" >> -export CFLAGS = "${TARGET_CFLAGS}" >> +SECURITY_CFLAGS ?= "" >> +export CFLAGS = "${TARGET_CFLAGS} ${SECURITY_CFLAGS}" >> export TARGET_CFLAGS = "${TARGET_CPPFLAGS} ${SELECTED_OPTIMIZATION}" > > I would prefer if the cflags came in via the TARGET_CFLAGS, similar to how > the selected_optimization works. In the past we've hacked around with CFLAGS > itself and in the end it's always seem to have caused problems. By modifing > TARGET_CFLAGS instead, then the user can do (in a recipe): > > CFLAGS = "-fmy-custom-flag ${TARGET_CFLAGS}" yes infact it should be added via TARGET_CFLAGS > >> export BUILD_CXXFLAGS = "${BUILD_CFLAGS} -fpermissive" >> @@ -523,7 +524,8 @@ LINKER_HASH_STYLE_mips64 = "sysv" >> LINKER_HASH_STYLE_mips64el = "sysv" >> TARGET_LINK_HASH_STYLE ?= >> "${@['-Wl,--hash-style=gnu',''][d.getVar('LINKER_HASH_STYLE', True) != >> 'gnu']}" >> >> -export LDFLAGS = "${TARGET_LDFLAGS}" >> +SECURITY_LDFLAGS ?= "" >> +export LDFLAGS = "${TARGET_LDFLAGS} ${SECURITY_LDFLAGS}" > > Same comment here. > >> export TARGET_LDFLAGS = "-Wl,-O1 ${TARGET_LINK_HASH_STYLE}" >> #export TARGET_LDFLAGS = "-L${STAGING_DIR_TARGET}${libdir} \ >> # -Wl,-rpath-link,${STAGING_DIR_TARGET}${libdir} \ >> > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core