On 08/08/2013 10:23 AM, Khem Raj wrote:
On Wednesday, August 7, 2013, ChenQi <qi.c...@windriver.com
<mailto:qi.c...@windriver.com>> wrote:
> On 08/07/2013 10:18 PM, Chris Larson wrote:
>
> On Wed, Aug 7, 2013 at 1:08 AM, <qi.c...@windriver.com
<mailto:qi.c...@windriver.com>> wrote:
>>
>> From: Chen Qi <qi.c...@windriver.com <mailto:qi.c...@windriver.com>>
>>
>> The init script for irda writes configuration items to
/etc/sysconfig/irda
>> if that file is not available in system. But it's actually not
necessary,
>> the behavior doesn't change whether the init script writes to the
file or not.
>>
>> Considering it issues error messages in case of a read-only rootfs,
I delete
>> the writing process.
>>
>> [YOCTO #4103]
>> [YOCTO #4886]
>>
>> Signed-off-by: Chen Qi <qi.c...@windriver.com
<mailto:qi.c...@windriver.com>>
>
> This is a start, but is incomplete, from what I can tell. As
mentioned in the other thread, the startup script shouldn't be using
/etc/sysconfig/ at all, in any form. We use /etc/default/ for our
startup script config files, not /etc/sysconfig/.
>
> Yeah, I agree with you.
> But when I checked the irda source code, I saw that it actually
could ship its own init script (irda-utils-xxx/etc/irda.rc). And I
think our init script is derived from this one. In its own init
script, /etc/sysconfig is used.
> (Of course, I still think /etc/default is a better location for its
configuration file.)
>
>
> Also, the purpose of this block was clearly to implement a default
configuration, yet the recipe isn't altered to ship a default
configuration to provide equivalent functionality.
>
> In its source code, there's a default configuration file, and we
don't use that. I think there might be a reason.
> So I'm not sure about this one.
>
> If you have a patch to fix the irda issue properly, send it out and
I'll rebase my remote branch and drop this one.
Whether Chris has a patch or not this patch in its form should be
dropped since there is a better way to do it
Shipping a default configuration file or using /etc/default as the
configuration directory? Or something else?
//Chen Qi
>
> Best Regards,
> Chen Qi
>
>
> --
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics
>
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
