On Mon, Nov 18, 2013 at 04:54:42PM +0100, Martin Jansa wrote:
> On Mon, Nov 18, 2013 at 12:31:15PM +0000, Richard Purdie wrote:
> > On Sun, 2013-11-17 at 14:52 +0100, Martin Jansa wrote:
> > > * typical case where we inherit allarch and override PACKAGE_ARCH
> > > are packagegroup recipes, but those need default dependencies
> > > inhibited even when they are MACHINE_ARCH or TUNE_PKGARCH.
> > > I don't know about any recipe which inherits allarch and needs
> > > default dependencies.
> >
> > The code there was added to allow the allarch class to be enabled or
> > disabled. I don't remember exactly why we needed to do that however it
> > was added for a reason and making part of it unconditional again will
> > probably break whyever we made it optional :(.
>
> I think that use case was MACHINE_ARCH packagegroups loosing -gnueabi
> suffix, so that everything except packagegroups (or other MACHINE_ARCH
> allarch recipes) was built in workdir:
> MACHINE-oe-linux-gnueabi
> and packagegroups in
> MACHINE-oe-linux
>
> I don't think we had the use case where we needed to conditionally keep
> default deps (but of course my memory isn't perfect and I can be wrong).
>
> > I can understand how you came to this conclusion though. Which cases is
> > this causing problems for?
> >
> > > * set empty TARGET_PREFIX
> > > This has a bit weird reason caused by unsupported setup where
> > > external-toolchain is used in some DISTRO only for some MACHINEs
> > > and internal is used for other MACHINEs.
> > > Because external-toolchain usually comes with different TARGET_PREFIX
> > > it was causing allarch recipes to have different signatures even
> > > when they don't use toolchain at all.
> > > Empty TARGET_PREFIX also helps to find allarch recipes which still
> > > have default dependency on e.g. virtual/${TARGET_PREFIX}gcc.
> >
> > This seems ok, I'd have taken it if it was a separate patch.
>
> It's related to above, because "thanks" to empty TARGET_PREFIX I've
> found few MACHINE_ARCH+allarch recipes in meta-webos which weren't using
> toolchain, but default deps had nonexistent "virtual/gcc".Ah sorry this wasn't very accurate, I've found it with earlier version of this patch which was unconditionally inhibiting default deps only for packagegroup.bbclass not allarch.bbclass where it should be. -- Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com
signature.asc
Description: Digital signature
_______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
