On Thu, Jan 23, 2014 at 10:21 AM, Richard Purdie <richard.pur...@linuxfoundation.org> wrote: > On Thu, 2014-01-23 at 07:04 +0000, Phil Blundell wrote: >> On Wed, 2014-01-22 at 22:50 -0800, Saul Wold wrote: >> > +IS_VMDK = '${@base_contains("IMAGE_FSTYPES", "vmdk", "true", "false", d)}' >> > + >> > + if [ "${IS_VMDK}" ]; then >> >> Does that really work? I can't quite see how it would, but I might be >> overlooking something. Presumably you did test this, right? > > I've merged this since I really would like to try and get the builds > stabilised. I did fix the patch since it would always evaluate as true > the way it was...
What is the point in having: + if [ "${IS_VMDK}" = "true" ]; then This is an indirection that buys nothing. - if [ ${IMAGE_FSTYPE} != "vmdk" ]; then - dd if=$HDDIMG of=$IMAGE conv=notrunc seek=1 bs=512 - dd if=${ROOTFS} of=$IMAGE conv=notrunc seek=$OFFSET bs=512 - fi + dd if=$HDDIMG of=$IMAGE conv=notrunc seek=1 bs=512 + dd if=${ROOTFS} of=$IMAGE conv=notrunc seek=$OFFSET bs=512 This changes the logic but commit log is not clear /what/ it fixes. I did valid comments in the patch and you didn't considered those. I just wasted time reviewing it... -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core