On Saturday 09 August 2014 09:17:16 Robert P. J. Day wrote: > On Fri, 8 Aug 2014, Saul Wold wrote: > > On 08/08/2014 12:31 PM, Robert P. J. Day wrote: > > > Given that there are no machine-specific files for the tslib recipe > > > anymore, might as well remove this line. > > > > Robert, > > > > Can you please review the commit guidelines > > > > http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines > > > > The summary line should be in the form of > > tslib: Remove ... > > serious question -- how does one identify the "primary item" under > consideration if it's scattered over several files. recently, i > submitted a patch to remove a few references to "do_package_write", > a deleted task. the existing references under meta/: > > conf/documentation.conf:do_package_write[doc] = "Creates the actual packages > and places them in the Package Feed area" > recipes-core/meta/meta-ide-support.bb:do_populate_ide_support[recrdeptask] > = "do_package_write" > recipes-core/meta/package-index.bb:do_package_write[noexec] = "1" > recipes-devtools/installer/adt-installer_1.0.bb:do_package_write[noexec] = > "1" > > i'm assuming, in this case, the primary item would be > "do_package_write"?
When you're making a blanket change like this it's OK to not have a "primary item". Most of the time though you end up changing just one recipe or class at a time, and then you should specify it. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core