Hello, >From my experience with ptest, there will always be a few tests failing, so we >will always get exit code 1. Should this better return exit code 0 if the >individual tests performed correctly(weather they passed or failed) and 1 if >there were any errors during the running of the tests?
Regards, Corneliu Yocto QA > -----Original Message----- > From: openembedded-core-boun...@lists.openembedded.org > [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf > Of root@myhostname > Sent: Friday, August 22, 2014 5:05 PM > To: openembedded-core@lists.openembedded.org > Subject: [OE-core] [PATCH] ptest-runner: return 1 instead of zero if any test > fails > > From: Laszlo Papp <lp...@kde.org> > > It is better to know this information from the exit code rather than parsing > test specific outputs. > > Signed-off-by: Laszlo Papp <lp...@kde.org> > --- > meta/recipes-support/ptest-runner/files/ptest-runner | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-support/ptest-runner/files/ptest-runner > b/meta/recipes-support/ptest-runner/files/ptest-runner > index 3342413..c618f11 100644 > --- a/meta/recipes-support/ptest-runner/files/ptest-runner > +++ b/meta/recipes-support/ptest-runner/files/ptest-runner > @@ -1,5 +1,5 @@ > #!/bin/sh > - > +ANYFAILED=no > echo "START: $0" > > for libdir in /usr/lib* > @@ -15,9 +15,13 @@ do > date "+%Y-%m-%dT%H:%M" > echo "BEGIN: $x" > cd "$x" > - ./run-ptest > + ./run-ptest || ANYFAILED=yes > echo "END: $x" > date "+%Y-%m-%dT%H:%M" > done > done > echo "STOP: $0" > +if [ "$ANYFAILED" = "yes" ]; then > + exit 1 > +fi > +exit 0 > -- > 2.0.4 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core