Hi, In my opinion, in the actual form, this patch cannot be taken in. Reasons/questions: 1. How exactly this has been tested? I don't see any details. Testing network configs and doing modifications of this kind are sensible matters. 2. Different images have different ways of setting up network; for example, core-image-sato will manage network setup using conmman; has this configuration been tested? 3. How exactly is decided if networkd is active or not in a systemd-based Linux image? 4. Please go into details why exactly this patch has been submitted (what it tries to solve in the first place).
Regards, Cristian -----Original Message----- From: openembedded-core-boun...@lists.openembedded.org [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf Of Hongxu Jia Sent: Monday, November 3, 2014 9:38 AM To: openembedded-core@lists.openembedded.org; Burton, Ross; Chen, Qi (Wind River) Subject: [OE-core] [PATCH 0/1] systemd: add network config while networkd supported The following changes since commit f19b4e995ea47f9243f152b39337330307453c9f: bitbake: bitbake: clarify startup message (2014-10-30 13:39:52 +0000) are available in the git repository at: git://git.pokylinux.org/poky-contrib hongxu/fix-systemd-network http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-systemd-network Hongxu Jia (1): systemd: add network config while networkd supported meta/recipes-core/systemd/systemd/oe-core.network | 8 ++++++++ meta/recipes-core/systemd/systemd_216.bb | 6 ++++++ 2 files changed, 14 insertions(+) create mode 100644 meta/recipes-core/systemd/systemd/oe-core.network -- 1.9.1 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
