On 2015年07月14日 11:11, Robert Yang wrote:
On 07/14/2015 10:10 AM, zhangxiao wrote:
On 2015年07月14日 09:47, Christopher Larson wrote:
On Mon, Jul 13, 2015 at 6:19 PM, zhangxiao <xiao.zh...@windriver.com
<mailto:xiao.zh...@windriver.com>> wrote:
On 2015年07月13日 22:28, Christopher Larson wrote:
On Sun, Jul 12, 2015 at 11:10 PM, Zhang Xiao
<xiao.zh...@windriver.com <mailto:xiao.zh...@windriver.com>
<mailto:xiao.zh...@windriver.com
<mailto:xiao.zh...@windriver.com>>> wrote:
Upstream-Status: pending
Signed-off-by: Zhang Xiao <xiao.zh...@windriver.com
<mailto:xiao.zh...@windriver.com>
<mailto:xiao.zh...@windriver.com
<mailto:xiao.zh...@windriver.com>>>
There’s no info on why this is being done, only what’s being
done, in
this commit message.
Binary logrotate should be installed in /usr/sbin and int fact, at
the very
beginning, it was there. While with commit a46d3646a3e1781be44:
...
logrotate: obey our flags
Needed to quiet GNU_HASH warnings, and some minor fixes.
...
Part of its modification as below:
...
- oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir}
+ oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir}
BINDIR=${bindir}
...
moves it to /usr/bin. It is not correct, so move it back to
/usr/sbin with ${sbindir}.
That’s entirely reasonable, but at least some reference to that needs to
be in the commit message, not just email discussion :)
So, How about:
Commit a46d36 moves logrotate to /usr/bin by mistake. Fix it.
I think that you can your last email as the commit message:
Binary logrotate should be installed in /usr/sbin, at the very
beginning, it was there. While with commit a46d3646a3e1781be44:
...
logrotate: obey our flags
Needed to quiet GNU_HASH warnings, and some minor fixes.
...
Part of its modification as below:
...
- oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir}
+ oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir}
BINDIR=${bindir}
...
moves it to /usr/bin. It is not correct, so move it back to
/usr/sbin with ${sbindir}.
Get it, I will send a new patch.
Thanks
Xiao
// Robert
Thanks
Xiao
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
