The git operations can fail, for example when the branch is unknown or misconfigured.
Better move the info message and extend it such that it is printed first and provides the necessary context, because otherwise the CalledProcessError exception gets dumped without mentioning for which component it occurred. Signed-off-by: Patrick Ohly <patrick.o...@intel.com> --- scripts/combo-layer | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/combo-layer b/scripts/combo-layer index 70dad83..7380f5b 100755 --- a/scripts/combo-layer +++ b/scripts/combo-layer @@ -585,8 +585,8 @@ def action_pull(conf, args): repo = conf.repos[name] ldir = repo['local_repo_dir'] branch = repo.get('branch', "master") + logger.info("update branch %s of component repo %s in %s ..." % (branch, name, ldir)) runcmd("git checkout %s" % branch, ldir) - logger.info("update component repo %s in %s ..." % (name, ldir)) if not conf.hard_reset: output=runcmd("git pull --ff-only", ldir) logger.info(output) -- 2.1.4 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core