> On Aug 6, 2015, at 1:38 AM, Paul Eggleton <paul.eggle...@linux.intel.com> > wrote: > > On Wednesday 05 August 2015 20:33:48 Khem Raj wrote: >> On Wed, Aug 5, 2015 at 2:01 AM, Ed Bartosh <ed.bart...@linux.intel.com> > wrote: >>> create-pull-request -d path creates empty patches if directory >>> is specified as a path, i.e. ./bitbake or ./bitbake/ or full path. >>> It behaves expected way only if script is run with -d bitbake, i.e. >>> relative dir name doesn't contain '\'. >>> >>> Fixed this unwanted behaviour by changing directory and running >>> git format-patch in it with --relative, without specifying >>> relative path as a parameter. >>> >>> Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> >>> --- >>> >>> scripts/create-pull-request | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/scripts/create-pull-request b/scripts/create-pull-request >>> index 216edfd..7eac618 100755 >>> --- a/scripts/create-pull-request >>> +++ b/scripts/create-pull-request >>> @@ -177,12 +177,15 @@ mkdir $ODIR >>> >>> if [ -n "$RELDIR" ]; then >>> >>> ODIR=$(realpath $ODIR) >>> >>> - extraopts="--relative=$RELDIR" >>> + pushd $RELDIR >> >> can we avoid using pushd so it works with non bash shells too ? > > Should be possible, but it's worth mentioning that this script already starts > with #!/bin/bash.
Does it have to be ? > > Cheers, > Paul > > -- > > Paul Eggleton > Intel Open Source Technology Centre
signature.asc
Description: Message signed with OpenPGP using GPGMail
-- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
