Hi Richard,
On 18/12/15 14:22, "Richard Purdie" <richard.pur...@linuxfoundation.org> wrote:
>On Fri, 2015-12-18 at 10:39 +0200, Markus Lehtonen wrote:
>> Copy kernel .config from ${S} to ${B}, instead of moving it. This
>> prevents mangling the source tree, which is undesirable e.g. when
>> externalsrc is used.
>>
>> Signed-off-by: Markus Lehtonen <markus.lehto...@linux.intel.com>
>> ---
>> meta/classes/kernel.bbclass | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/kernel.bbclass
>> b/meta/classes/kernel.bbclass
>> index 4ce1611..7de9f20 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -338,7 +338,7 @@ kernel_do_configure() {
>> touch ${B}/.scmversion ${S}/.scmversion
>>
>> if [ "${S}" != "${B}" ] && [ -f "${S}/.config" ] && [ ! -f
>> "${B}/.config" ]; then
>> - mv "${S}/.config" "${B}/.config"
>> + cp "${S}/.config" "${B}/.config"
>> fi
>>
>> # Copy defconfig to .config if .config does not exist. This
>> allows
>
>I'm not sure about this, doesn't this trigger the kernel to see ${S} as
>being 'dirty' and cause other issues when you try and do out of tree
>builds with it?
That shouldn't be a problem as the kernel .gitignore ignores .config (or '.*'
to be more specific). There are other tasks that make changes to the kernel
source tree, as well, like do_kernel_metadata.
>It also means we have two copies of "config" around which can end up
>being different and confuse users no end :(.
Yes, I must agree. What do you think if ${B}/.config would be a symlink to
${S}/.config? I.e.
+ ln -s "${S}/.config" "${B}/.config"
Thanks,
Markus
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
