> -----Original Message----- > From: openembedded-core-boun...@lists.openembedded.org > [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf Of > Richard Purdie > Sent: den 11 maj 2016 23:35 > To: Peter Kjellerstedt; openembedded-core@lists.openembedded.org > Subject: Re: [OE-core] [PATCH 00/16] Simplify how to stage directories in the > sysroot > > On Wed, 2016-05-11 at 19:27 +0200, Peter Kjellerstedt wrote: > > The first commit in this set makes it possible to specify the > > directories that will be staged in the sysroot via variables rather > > than hardcoding it in sysroot_stage_dirs(). This should make it a lot > > easier to add/remove directories to stage. > > > > The rest of the commits just change recipes to take advantage of the > > new variables. > > > > Because of the following if statement in sysroot_stage_dirs(): > > > > if [ "${BUILD_SYS}" = "${HOST_SYS}" ]; then > > > > I have split the list of directories into SYSROOT_DIRS and > > SYSROOT_DIRS_NATIVE, where the latter is included if that if statement > > is true. I am not sure when that statement is true (my understanding > > is that it should be true for native builds, but I am not sure if it > > is also true for other builds like cross, nativesdk, etc). If it is > > only true for native builds then that if statement could be removed, > > and the SYSROOT_DIRS_NATIVE variable could be replaced by > > SYSROOT_DIRS_append_class-native... > > It matches binaries that can run on the build system so it needs to > match native and cross. Something like: > > SYSROOT_DIRS_append_class-native = "${SYSROOT_DIRS_NATIVE}" > SYSROOT_DIRS_append_class-cross = "${SYSROOT_DIRS_NATIVE}"
Apparently it is true for crossssdk as well (I ran recipes from each of the five classes through bitbake -e to verify). I will send an updated patch that uses the _append solution instead. > I hadn't realised how much duplication there was in that class. Cleanup > I'd never gotten around to doing. I guess most people don't even > remember how we ended up with that code or the horrors of do_stage > functions :) I looked at some of the horrors in the git log while investigating how it works. I am glad you got rid of them. ;) > Cheers, > > Richard //Peter -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core