yes, good point. I will resend the patch with an updated commit 
message.

> -----Original Message-----
> From: Khem Raj [mailto:raj.k...@gmail.com]
> Sent: Monday, October 17, 2016 4:38 PM
> To: Bystricky, Juro <juro.bystri...@intel.com>
> Cc: openembedded-core@lists.openembedded.org; jurobystri...@hotmail.com
> Subject: Re: [OE-core] [PATCH] insane.bbclass: Additional "mips" and
> "mipsel" machine definitions
> 
> 
> > On Oct 11, 2016, at 9:56 AM, Juro Bystricky <juro.bystri...@intel.com>
> wrote:
> >
> > Add "mips" and "mipsel" to "machdata" table.
> > Although there is a way to add entries to the "machdata" table
> > from a BSP without modifying the insane.bbclass directly, MIPS is
> > already supported in poky and as such the relevant entries should be
> > present in insane.bbclass.
> 
> perhaps say s/poky/openembedded-core/ here since thats where the patch
> is going to go.
> 
> >
> > Signed-off-by: Juro Bystricky <juro.bystri...@intel.com>
> > ---
> > meta/classes/insane.bbclass | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> > index b347638..21c5cda 100644
> > --- a/meta/classes/insane.bbclass
> > +++ b/meta/classes/insane.bbclass
> > @@ -66,6 +66,8 @@ def package_qa_get_machine_dict(d):
> >                         "i586" :      (3,      0,    0,          True,
> 32),
> >                         "x86_64":     (62,     0,    0,          True,
> 64),
> >                         "epiphany":   (4643,   0,    0,          True,
> 32),
> > +                        "mips":       ( 8,     0,    0,          False,
> 32),
> > +                        "mipsel":     ( 8,     0,    0,          True,
> 32),
> >                       },
> >             "linux" : {
> >                         "aarch64" :   (183,    0,    0,          True,
> 64),
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to