On Thu, Nov 10, 2016 at 9:33 PM, Maciej Borzęcki <[email protected]> wrote: > On Thu, Nov 10, 2016 at 9:15 PM, Burton, Ross <[email protected]> wrote: >> >> On 10 November 2016 at 12:18, Maciej Borzecki <[email protected]> >> wrote: >>> >>> def test_qemux86_directdisk(self): >>> """Test creation of qemux-86-directdisk image""" >>> image = "qemux86-directdisk" >>> - self.assertEqual(0, runCmd("wic create %s -e core-image-minimal" >>> \ >>> - % image).status) >>> + wic_cmd_vars = { >>> + 'wks': image, >>> + 'image': self.OE_IMAGE, >>> + } >>> + self.assertEqual(0, runCmd("wic create %(wks)s -e %(image)s" \ >>> + % wic_cmd_vars).status) >> >> >> Is it just me who thinks that this is more understandable then? >> >> def test_qemux86_directdisk(self): >> self.assertEqual(0, runCmd("wic create qemux86-directdisk -e >> core-image-minimal").status) >> self.assertEqual(1, len(glob(os.path.join(self.resultdir, >> "core-image-minimal-*direct")))) >> >> Not my test case so just an opinion :) >> > > Now that I look at this patch, I probably might have overdone it a little. > Let's > wait and see what Ed thinks about this change. I suppose there might be a need > for v3 of this series, in which case I'll just drop this patch and rebase the > remaining patches.
Ed, did you get a chance to review this series? Cheers, -- Maciej Borzecki RnDity -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
