On Wed, Nov 30, 2016 at 02:30:12PM +0100, Kristian Amlie wrote: > On 28/11/16 12:18, Ed Bartosh wrote: > > I'd appreciate if you also do the following before sending v2: > > - check that your code doesn't regress pylint checks > > Is there an official process here? Sorry, it's not very well documented. No official process yet, I'm sorry. I can put it on wiki if it helps.
> Just running pylint3 manually on the scripts/lib/wic folder gives > identical results, however, running on rootfs.py alone, the rating > increases: > > Your code has been rated at 5.67/10 (previous run: 2.26/10, +3.41) Looks good to me. Thanks. Running pylint on the files you've changed before and after the changes should be enough. > > - add test case for your code to meta/lib/oeqa/selftest/wic.py > > - check that your code doesn't break oe-selftest --coverage -r wic and > > doesn't regress test coverage > > In the interest of saving me some build time, am I correct in assuming > that I need the "qemux86-64" MACHINE target for this to work? It appears > to be dependent on syslinux which has COMPATIBLE_HOSTS set to non-arm > only. Sorry, I'm a bit new to this framework. > You're right. oe-selftest requires qemux86-64 target. Even if you usually work in different environment it makes sense to run oe-selftest to ensure that your changes don't breake it. This is because our maintainers use oe-selftest results as one of the acceptance criterias. It means that your changes would be be rejected anyway if they break oe-selftest, so it's better to check it in advance. -- Regards, Ed -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
