On Thu, 2017-03-09 at 21:05 +0100, Patrick Ohly wrote: > On Wed, 2017-03-08 at 17:24 +0000, Joshua Lock wrote: > > The oe-selftest oescripts.TestScripts.test_cleanup_workdir was > > using > > gzip and the GPLv2 variant to test cleanup of the workdir. This > > broke > > with the removal of GPLv2 recipes from OE-Core. > > > > Instead of relying on recipes in OE-Core remaining static we should > > ensure that meta-selftest provides recipes required for the tests > > to pass. > > To that end we take a copy of the current GPLv2 and GPLv3 variants > > of ed > > and include them in meta-selftest as new recipes. > > We chose ed over gzip as gzip has dependencies which would require > > additional GPLv2 recipes to be included in meta-selftest. > > Wouldn't the test become faster when using artificial recipes, i.e. > something which doesn't really need sources? Such an artificial > recipe > can use a local file as its "source", for example.
Indeed, that would make the test faster. I took a shorter route for this series in an attempt to unblock M3, however I realise that the bitbake targets used in oe-selftest could do with a consistent review. I've filed an enhancement request to that effect: https://bugzilla.yoctoproject.org/show_bug.cgi?id=11142 > Or did I misunderstand something and the selftest doesn't really > build > ed? It does build ed, which is an improvement over building gzip but not as fast as something artificial. Thanks for the feedback, Joshua -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core