Thanks for the review. We will upstream the V3 patch once amended. Thanks and Regards Choong YinThong
-----Original Message----- From: Alexander Kanavin [mailto:alexander.kana...@linux.intel.com] Sent: Tuesday, April 4, 2017 6:40 PM To: openembedded-core@lists.openembedded.org; Choong, Yin Thong <yin.thong.cho...@intel.com> Subject: Re: [OE-core] [PATCH v2 4/8] logrotate: replace fedorahosted.org SRC_URI with github.com source On 04/04/2017 12:29 PM, yin.thong.cho...@intel.com wrote: > -SRC_URI = > "https://fedorahosted.org/releases/l/o/logrotate/logrotate-${PV}.tar.g > z \ > +S = "${WORKDIR}/${PN}-r3-9-1" > + > +UPSTREAM_CHECK_URI = "https://github.com/${PN}/${PN}/releases"; > + > +SRC_URI = "https://github.com/${PN}/${PN}/archive/r3-9-1.tar.gz \ Why are we taking a github snapshot tarball (which is not standard parctice in oe-core)? Put a comment here that when updating logrotate to latest upstream, SRC_URI should point to a proper release tarball from https://github.com/logrotate/logrotate/releases and we have to take the snapshot for now because there is no such tarball available for 3.9.1. Generally, don't be afraid to put comments next to your changes, the more the better! And especially when you are doing something unusual that is not self-explanatory like above. Otherwise, I am happy with the patchset! Alex -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
