This now breaks parsing my distro config on these lines: ENABLE_SYSVINIT ?= "0" DISTRO_FEATURES_append = "${@base_conditional("ENABLE_SYSVINIT", "1", "", " systemd", d)}"
Here's the log: ERROR: Unable to parse /OE/arago-master/sources/bitbake/lib/bb/data_smart.py Traceback (most recent call last): File "/OE/arago-master/sources/bitbake/lib/bb/data_smart.py", line 426, in DataSmart.expandWithRefs(s='${@base_conditional("ENABLE_SYSVINIT", "1", "", " systemd", d)}', varname='DISTRO_FEATURES_append'): except Exception as exc: > raise ExpansionError(varname, s, exc) from exc bb.data_smart.ExpansionError: Failure expanding variable DISTRO_FEATURES_append, expression was ${@base_conditional("ENABLE_SYSVINIT", "1", "", " systemd", d)} which triggered exception NameError: name 'base_conditional' is not defined -- Denys On Fri, Jun 09, 2017 at 03:04:03PM +0200, Patrick Ohly wrote: > As discussed in "[Openembedded-architecture] Yocto Compatible 2.0 + > signature changes", changes in .bbappend must depend on some explicit > configuration change, typically selecting a distro feature. > > For _append and _remove, adding an override that is set only when the > corresponding entry is in DISTRO_FEATURES achieves that: > > In local.conf: > DISTRO_FEATURES_append = " my-distro-feature" > > In layer.conf: > DISTRO_FEATURES_OVERRIDES += "my-distro-feature" > > In a .bbappend: > do_install_append_df-my-distro-feature () { > ... > } > > The subset of DISTRO_FEATURES that are made available as overrides > must be configured explicitly because using them this way should > be a conscious decision. > > Signed-off-by: Patrick Ohly <patrick.o...@intel.com> > --- > meta/conf/bitbake.conf | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index 3ad905c..fce1882 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -713,7 +713,7 @@ DISTRO_NAME ??= "OpenEmbedded" > # > # This works for functions as well, they are really just environment > variables. > # Default OVERRIDES to make compilation fail fast in case of build system > misconfiguration. > -OVERRIDES = > "${TARGET_OS}:${TRANSLATED_TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:${CLASSOVERRIDE}:forcevariable" > +OVERRIDES = > "${TARGET_OS}:${TRANSLATED_TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}${DISTROFEATURESOVERRIDES}:${CLASSOVERRIDE}:forcevariable" > OVERRIDES[vardepsexclude] = "MACHINEOVERRIDES" > CLASSOVERRIDE ?= "class-target" > DISTROOVERRIDES ?= "${@d.getVar('DISTRO') or ''}" > @@ -722,6 +722,21 @@ MACHINEOVERRIDES[vardepsexclude] = "MACHINE" > > FILESOVERRIDES = > "${TRANSLATED_TARGET_ARCH}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}" > > +# Turns certain DISTRO_FEATURES into overrides of the same name > +# or (optionally) some other name. Ensures that these special > +# distro features remain set also for native and nativesdk > +# recipes, so that these overrides can also be used there. > +# > +# Beware that this part of OVERRIDES changes during parsing, so usage > +# of these overrides should be limited to .bb and .bbappend files, > +# because then DISTRO_FEATURES is final. > +DISTRO_FEATURES_OVERRIDES ??= "" > +DISTRO_FEATURES_OVERRIDES[doc] = "A space-separated list of <feature> > entries. \ > +Each entry is added to OVERRIDES as df-<feature> if <feature> is in > DISTRO_FEATURES." > +DISTRO_FEATURES_FILTER_NATIVE_append = " ${DISTRO_FEATURES_OVERRIDES}" > +DISTRO_FEATURES_FILTER_NATIVESDK_append = " ${DISTRO_FEATURES_OVERRIDES}" > +DISTROFEATURESOVERRIDES = "${@ ''.join([':df-' + x for x in > (set(d.getVar('DISTRO_FEATURES_OVERRIDES').split()) & > set((d.getVar('DISTRO_FEATURES') or '').split()))]) }" > + > ################################################################## > # Include the rest of the config files. > ################################################################## > -- > git-series 0.9.1 > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core