On Thu, Jul 27, 2017 at 10:14:15PM +0100, Richard Purdie wrote: > On Thu, 2017-07-27 at 12:20 -0400, Tom Rini wrote: > > On Thu, Jul 27, 2017 at 04:08:40PM +0000, Wold, Saul wrote: > > > > > > On Tue, 2017-07-25 at 15:58 -0400, Tom Rini wrote: > > > > > > > > The vmdk/vdi/qcow2 IMAGE_FSTYPEs predate wic. As such, they > > > > provide > > > > some similar underlying functionality in order to produce a > > > > "disk" > > > > image > > > > that in turn can be converted into different formats that various > > > > hypervisor types work with. They do not however provide the > > > > ability > > > > for > > > > other disk image types to be converted into these same output > > > > types. > > > > Furthermore, they are less flexible than what wic does > > > > provide. This > > > > drops the old style vmdk/vdi/qcow2 types and re-introduces them > > > > under > > > > the CONVERSION_CMD framework. The equivalent of vmdk is now > > > > wic.vmdk > > > > and so forth for the other types. > > > > > > > I like this also! Strong work! > > > > > > Would this allow us to further collapse the live-vm-common.bbclass > > > back > > > to just image-live.bbclass. I know that the magic mapping that > > > happens > > > in set_live_vm_vars() has caused confusion in the past and removing > > > that mapping would be pretty awesome. > > Yes, with this there is only one user of live-vm-common.bbclass, so > > it could be folded back. > > This patchset looks to have caused a number of selftest failures: > > https://autobuilder.yocto.io/builders/nightly-oe-selftest/builds/409/steps/Running%20oe-selftest/logs/stdio > > I suspect there are some testcases which need updating with this > change, would you be able to take a look please?
Ah, I was warned there's a full test-suite that takes longer. I see they're all in runqemu, I'll kick those off locally and post a v3 once I've got them fixed. Thanks! -- Tom
signature.asc
Description: Digital signature
-- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core