Frans Meulenbroeks wrote:
2010/9/8 Tom Rini <[email protected]>:
Khem Raj wrote:
On Wed, Sep 8, 2010 at 10:41 AM, Frans Meulenbroeks
<[email protected]> wrote:
Hi
While browsing through a recipe I stumbled upon the following two
functions:
[snip]
do_install() {
make install DESTDIR=${D}
}
this if used in a recipe which inherits autotools could be for getting
parallelism out of context during install but not during compile.
again this kind of stuff should be avoided.
Not true (but I had to double check just now, so it's quite possible some
others have assumed this behavior). If we look at bitbake.conf:
EXTRA_OEMAKE_prepend_task_do_compile = "${PARALLEL_MAKE} "
EXTRA_OEMAKE_prepend_task-compile = "${PARALLEL_MAKE} "
So in the case of literally having DESTDIR=${D}, these can just go away.
There are some annoying cases however where it's not DESTDIR but some other
variable. IMHO, it's questionable if it'd be cleaner to do a custom one
line do_install vs EXTRA_OEMAKE_append_task-do_install = "PREFIX=${D}"
Woudht aht have to be an EXTRA_OEMAKE_append_task-do_install ?
I see also recipes that just add PREFIX or DESTDIR to EXTRA_OEMAKE
(actually I would expect the presence or absence not to be an issue in
most cases (as DESTDIR is quite likely not used during compile)
Yes, it could also probably live in just plain old EXTRA_OEMAKE.
Another task for the janitors page I suppose :)
--
Tom Rini
Mentor Graphics Corporation
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
