On Tue, Jan 11, 2011 at 11:19:42PM +0100, Andreas Oberritter wrote: >Hello Bernhard, > >thanks for your review. When creating the patch I tried to use the least >invasive way, i.e. to change as few lines of code as possible, in order >not to break anything. Most of your remarks apply to already existing >code which was either copied or indented. I think, that your suggestions >should be incorporated in a later patch by someone more experienced in >python than me.
>> a default of False to to_boolean -- which will return False "if not >> string" (and should >> if not string or not isinstance(string, basestring): the isinstance remark is of course nonsense, please disregard it. >> return False >> , as a sidenote) >> is superfluous. >That's just changed indentation of already existing code. So let's leave the potential cleanup for a future patch. Reviewed-by: Bernhard Reutner-Fischer <rep.dot....@gmail.com> _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel