Oops... hold on. Forgive me, but it does not compile. I mixed up a hyphen and underscore in this commit.
I'll resubmit in a few minutes... AJ ONeal On Wed, Feb 9, 2011 at 6:37 PM, Khem Raj <raj.k...@gmail.com> wrote: > On Wed, Feb 9, 2011 at 12:42 PM, Tom Rini <tom_r...@mentor.com> wrote: > > On 02/09/2011 01:08 PM, Koen Kooi wrote: > >> > >> -----BEGIN PGP SIGNED MESSAGE----- > >> Hash: SHA1 > >> > >> On 09-02-11 20:44, Tom Rini wrote: > >>> > >>> On 02/08/2011 10:58 AM, AJ ONeal wrote: > >>>> > >>>> * added version number to patches > >>>> * libev-cross-cc_0.2.6.patch - turns off execution so that > >>>> cross-compile succeeds > >>>> * node-cross-cc_0.2.6.patch - enables cross-compiling of v8 for x86, > >>>> x86_64, arm, and mips > >>> > >>> I didn't touch it in patchwork but (and I see these aren't all new > >>> issues): > >>> > >>>> diff --git a/recipes/nodejs/nodejs_0.2.6.bb > >>>> b/recipes/nodejs/nodejs_0.2.6.bb > >>>> new file mode 100644 > >>>> index 0000000..560adc6 > >>>> --- /dev/null > >>>> +++ b/recipes/nodejs/nodejs_0.2.6.bb > >>>> @@ -0,0 +1,32 @@ > >>>> +DESCRIPTION = "nodeJS Evented I/O for V8 JavaScript" > >>>> +HOMEPAGE = "http://nodejs.org" > >>>> +LICENSE = "MIT" > >>>> + > >>>> +DEPENDS = "openssl" > >>>> + > >>>> +SRC_URI = " \ > >>>> + http://nodejs.org/dist/node-v${PV}.tar.gz \ > >>>> + file://libev-cross-cc-v${PV}.patch \ > >>>> + file://node-cross-cc-v${PV}.patch \ > >>>> +" > >>>> +SRC_URI[md5sum] = "b1c50ceb43bee1b221be210b7bc7a216" > >>>> +SRC_URI[sha256sum] = > >>>> "e97fe9c81ff4b569ae9a0d46e64a0572a1f171293573a5b5290bcc3996a19701" > >>>> + > >>>> +S = "${WORKDIR}/node-v${PV}" > >>>> + > >>>> +# v8 errors out if you have set CCACHE > >>>> +CCACHE = "" > >>>> + > >>>> +do_configure () { > >>>> + ./configure --prefix=${prefix} --without-snapshot > >>>> +} > >>> > >>> Why isn't this just EXTRA_OECONF = "--without-snapshot" and using the > >>> default do_configure, compile and install? > >> > >> It's one of those python abominations that try to look like autotools :( > >> And as usual, it has even more bugs than autotools when you try to > >> crosscompile > > > > Retch. So, unless someone pops up within the next 24h and says why they > did > > something in patchwork or otherwise objects, I'll push this. Thanks! > > > > This patch has addressed the review comments. So please go ahead. > However this should be versioned for clarity if a patch is resent > > > -- > > Tom Rini > > Mentor Graphics Corporation > > > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > > > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel