Dear Pau,
thank you for your contribution.
Am Montag, den 13.06.2011, 19:52 +0200 schrieb Pau Espin Pedrol:
The commit summary is a bit long. Please add a blank line in between and
add your Signed-off-by line according to the commit policy [1].
Please also paste the important parts of the segfault into the commit
message.
What system did you use for testing?
> ---
> recipes/e17/enjoy_svn.bb | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes/e17/enjoy_svn.bb b/recipes/e17/enjoy_svn.bb
> index eab81b4..d709eb7 100644
> --- a/recipes/e17/enjoy_svn.bb
> +++ b/recipes/e17/enjoy_svn.bb
> @@ -3,7 +3,7 @@ LICENSE = "LGPLv3"
> DEPENDS = "evas ecore edje elementary emotion lightmediascanner"
> SRCREV = "${EFL_SRCREV}"
> PV = "0.0+svnr${SRCPV}"
> -PR = "r4"
> +PR = "r5"
>
> DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1',
> '', 'gst-plugins-ugly', d)}"
>
> @@ -13,7 +13,7 @@ DEPENDS += "gst-plugins-good
> ${@base_conditional('ENTERPRISE_DISTRO', '1', '', '
> #4th needed for flac playback
> #5th needed binary to create db
> RDEPENDS += "\
> - gst-plugin-typefindfunctions gst-plugin-playbin gst-plugin-volume
> gst-plugin-decodebin2 \
> + gst-plugin-typefindfunctions gst-plugin-playbin gst-plugin-volume
> gst-plugin-decodebin2 gst-plugin-alsa gst-plugin-autodetect \
> ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugin-mad
> gst-plugin-id3demux', d)} \
> gst-plugin-ogg gst-plugin-ivorbisdec \
> gst-plugin-flac \
Otherwise this looks good. Please resend as “v2” [2].
Thanks,
Paul
[1] http://openembedded.org/index.php/Commit_Policy
[2] http://openembedded.org/index.php/How_to_submit_a_patch_to_OpenEmbedded
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
