From: Fathi Boudra [mailto:fathi.bou...@linaro.org] Sent: Thursday, March 20, 2014 11:45 AM To: openembedded-devel@lists.openembedded.org Cc: Maupin, Chase Subject: Re: [oe] [PATCH] pm-qa-utils: Add power management test utils
On 20 March 2014 16:47, Chase Maupin <chase.mau...@ti.com<mailto:chase.mau...@ti.com>> wrote: * The power management test utilities from Linaro can be used to test multiple PM features such as cpufreq, cpuidle, thermal control and suspend operations. * These utilities are not platform specific and can be used by a broader base of users. Signed-off-by: Chase Maupin <chase.mau...@ti.com<mailto:chase.mau...@ti.com>> --- .../pm-qa-utils/pm-qa-utils_git.bb<http://pm-qa-utils_git.bb> | 63 ++++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 meta-oe/recipes-devtools/pm-qa-utils/pm-qa-utils_git.bb<http://pm-qa-utils_git.bb> diff --git a/meta-oe/recipes-devtools/pm-qa-utils/pm-qa-utils_git.bb<http://pm-qa-utils_git.bb> b/meta-oe/recipes-devtools/pm-qa-utils/pm-qa-utils_git.bb<http://pm-qa-utils_git.bb> new file mode 100644 index 0000000..610f3a7 --- /dev/null +++ b/meta-oe/recipes-devtools/pm-qa-utils/pm-qa-utils_git.bb<http://pm-qa-utils_git.bb> @@ -0,0 +1,63 @@ +DESCRIPTION = "Utilities from Linaro for testing Power Management" nitpick, I'll remove "from Linaro" :) [CEM] I have another version I need to send so I’ll take care of this. +HOMEPAGE = "https://wiki.linaro.org/WorkingGroups/PowerManagement/Resources/TestSuite/PmQa" + +LICENSE = "GPLv2" +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263<file:///\\COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263>" + +PV = "0.4.4" we released 0.4.8 today. [CEM] I’ll go ahead and bump this +BRANCH ?= "master" +SRCREV = "fbc2762359b863dfbf4fd0bab1e8abd2a6125ed4" + +SRC_URI = "git://git.linaro.org/tools/pm-qa.git;protocol=git;branch=${BRANCH}<http://git.linaro.org/tools/pm-qa.git;protocol=git;branch=$%7BBRANCH%7D>" + +S = "${WORKDIR}/git" + +CFLAGS += "-pthread" + +do_compile () { + # Find all the .c files in this project and build them. + for x in `find . -name "*.c"` + do + util=`echo ${x} | sed s/.c$//` + oe_runmake ${util} + done +} + +do_install () { + install -d ${D}${bindir} + install -d ${D}${bindir}/linaro-pm-qa-include + + # Install the compiled binaries the were built in the previous step + for x in `find . -name "*.c"` + do + util=`echo ${x} | sed s/.c$//` + util_basename=`basename ${util}` + install -m 0755 ${util} ${D}${bindir}/${util_basename} + done + + # Install the helper scripts in the include directory + for script in `find . -name "*.sh" | grep include` + do + # Remove hardcoded relative paths + sed -i -e 's#..\/utils\/##' ${script} + + script_basename=`basename ${script}` + install -m 0755 $script ${D}${bindir}/linaro-pm-qa-include/${script_basename} + done + + # Install the shell scripts NOT in the include directory since those + # will be installed elsewhere + for script in `find . -name "*.sh" | grep -v include` + do + # if the script includes any helper scripts from the include + # directory then change the include path to the absolute path + # to reflect the install location of the helper scripts. + sed -i -e "s#source ../include#source ${bindir}/linaro-pm-qa-include#g" ${script} + # Remove hardcoded relative paths + sed -i -e 's#..\/utils\/##' ${script} + + script_basename=`basename ${script}` + install -m 0755 $script ${D}${bindir}/${script_basename} + done we probably need to fix that properly and avoid the LTP style mess (software not meant to be installable). +} -- 1.7.9.5 -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org<mailto:Openembedded-devel@lists.openembedded.org> http://lists.openembedded.org/mailman/listinfo/openembedded-devel FWIW, my comments aren't a blocker/nack. That's something we can address later on. Cheers, Fathi -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel