On 11/13/2015 06:36 PM, Hongxu Jia wrote:
On 11/13/2015 06:19 PM, Martin Jansa wrote:
Why not use VIRTUAL-RUNTIME variable like in other places?
Hi Martin,
With more investigation, I am afraid it looks not good to rename
NETWORK_MANAGER in
oe-core:
In meta/recipes-sato/packagegroups/packagegroup-core-x11-sato.bb
......
NETWORK_MANAGER ?= "connman-gnome"
NETWORK_MANAGER_libc-uclibc = ""
RDEPENDS_${PN}-base = "\
...
${NETWORK_MANAGER} \
......
If we name them with VIRTUAL-RUNTIME_networkmanager to replace, we have
like this
......
VIRTUAL-RUNTIME_networkmanager ?= "connman-gnome"
VIRTUAL-RUNTIME_networkmanager_libc-uclibc = ""
RDEPENDS_${PN}-base = "\
...
${VIRTUAL-RUNTIME_networkmanager} \
......
It looks too many overrides, do you have any suggestions?
//Hongxu
If use it, I will rename NETWORK_MANAGER with
VIRTUAL-RUNTIME_networkmanager
in packagegroup-core-x11-sato, to see oe-core whether accept it or not.
And if it's
needed by xfce4-power-manager, then why don't you add it to RDEPENDS
there?
It is reasonable, add the variable(NETWORK_MANAGER or
VIRTUAL-RUNTIME_networkmanager) to xfce4-power-manager'S RDEPENDS
//Hongxu
On Fri, Nov 13, 2015 at 11:13 AM, Andreas Müller <
schnitzelt...@googlemail.com> wrote:
On Fri, Nov 13, 2015 at 11:04 AM, Hongxu Jia <hongxu....@windriver.com>
wrote:
The NETWORK_MANAGER is connman-gnome in oe-core by default,
which conflicts with networkmanager. And networkmanager is
required by xfce4-power-manager in meta-xfce. So we explicitly
set networkmanager to NETWORK_MANAGER for meta-xfce.
Signed-off-by: Hongxu Jia <hongxu....@windriver.com>
---
meta-xfce/conf/layer.conf | 3 +++
1 file changed, 3 insertions(+)
diff --git a/meta-xfce/conf/layer.conf b/meta-xfce/conf/layer.conf
index 55bcef6..e38d85d 100644
--- a/meta-xfce/conf/layer.conf
+++ b/meta-xfce/conf/layer.conf
@@ -17,3 +17,6 @@ LAYERDEPENDS_xfce-layer += "openembedded-layer"
LAYERDEPENDS_xfce-layer += "gnome-layer"
LAYERDEPENDS_xfce-layer += "openembedded-layer"
LAYERDEPENDS_xfce-layer += "meta-python"
+
+# It is required by xfce4-power-manager
+NETWORK_MANAGER = "networkmanager"
--
I was wondering why I never needed such kind of patch and checked: In
my layers It is only used in packagegroup-core-x11-sato.
So I am fine with this patch but could you mention
packagegroup-core-x11-sato in the commit message please.
Andreas
--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
