Hi Khem, Shall I generate a proper patch with the proper header? Or should Jacobo add that to his patch? I'm not even sure the patch is accepted on master yet.
Cheers, Herve > On 28 Jan 2017, at 01:51, Khem Raj <raj.k...@gmail.com> wrote: > > > > On 1/27/17 6:06 AM, Julien Brianceau (jbriance) wrote: >>> -----Original Message----- >>> From: openembedded-devel-boun...@lists.openembedded.org >>> [mailto:openembedded-devel-boun...@lists.openembedded.org] On Behalf Of >>> Khem Raj >>> Sent: vendredi 27 janvier 2017 02:47 >>> To: openembedded-devel@lists.openembedded.org >>> Subject: Re: [oe] [meta-browser][PATCH v2] chromium-wayland: update to >>> 53.0.2785.14 >>> >>> >>> >>>> On 1/25/17 9:50 PM, Herve Jourdain wrote: >>>> Hi Jacob, >>>> >>>> I've been able to compile chromium-wayland 53.0.2785.14 on >>> RaspberryPi, with Wayland only (no X11), BUT I had to add an additional >>> patch for it to work, or else I get an error in >>> ui/events/keycodes/keyboard_code_conversion_xkb.cc. >>>> I'm using VC4, which has a DRM/KMS interface (it seems that DRM >>> interface is required by ozone-wayland), but this patch seems to not be >>> related to RaspberryPi itself. >>>> Basically, it seems that USE_XKBCOMMON is not defined when compiling >>> keycodes. >>>> >>>> Is it something that you saw as well? Or do you have a different >>> setting/experience? >>>> >>>> Just for reference, here is the patch I need (right now, I'm >>> triggering it from meta-raspberrypi, but I believe it may be needed in >>> meta-browser). >>>> >>>> --- a/ui/events/keycodes/events_keycodes.gyp 2017-01-23 >>> 19:12:01.767271256 +0800 >>>> +++ b/ui/events/keycodes/events_keycodes.gyp 2017-01-23 >>> 19:12:11.503048216 +0800 >>>> @@ -21,6 +21,9 @@ >>>> 'scoped_xkb.h', >>>> 'xkb_keysym.h', >>>> ], >>>> + 'defines': [ >>>> + 'USE_XKBCOMMON', >>> >>> This seems fine to me. It should also be proposed upstream as well I >>> think. >>> >> >> For the record, I've already tried to upstream a similar change (see Patch >> Set 1 of review https://codereview.chromium.org/2239833003/), but only the >> GN part has been accepted as gyp support has been removed in Chromium 54. >> > > thats we should make a note of this in patch header. We will have to > remove it or replace it as well when we upgrade chromium. >> Julien >> > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel