The patch is already present in master, so I opted to send a patch rebased for dunfell. If there are any issues, please let me know.
Regards, Claude Bing On 5/9/20 2:54 PM, Steve Sakoman wrote: > Hi Claude, > > On Fri, May 8, 2020 at 11:26 AM Claude Bing <[email protected]> wrote: >> >> OK, I started a new patch thread. Who/what determines which patches get >> included in the named release branches? Specifically, we are using >> dunfell and would like these changes to show up in that branch. > > Just submit a patch to this list tagged with [dunfell]. In general > though I won't take a patch unless it is already in master, so a patch > for both master and dunfell should be tagged with [master][dunfell] > > If the issue is already fixed in master with a version bump, and a > version bump in dunfell would be too dangerous (i.e. feature changes) > then I'll take a patch to the current version in dunfell. Again, tag > it with [dunfell] and also mention the commit in master that fixes the > issue. > > Thanks, > > Steve > >> >> :) >> >> Regards, >> >> Claude Bing >> >> On 5/8/20 2:41 PM, Adrian Bunk wrote: >>> On Fri, May 08, 2020 at 10:42:22AM -0400, Claude Bing wrote: >>>> On 5/8/20 6:56 AM, Adrian Bunk wrote: >>>>> On Thu, May 07, 2020 at 02:28:06PM -0400, Claude Bing wrote: >>>>>> Explicitly specifying -lrt is required for opcache to be linked against >>>>>> the proper dependencies. Additionally, PHP disables libdl when it >>>>>> detects a cross-compilation environment for some reason. In order to >>>>>> load any type of extension, re-enabling libdl is required. >>>>>> ... >>>>>> +# link against librt (libc) if opcache is specified in order to avoid >>>>>> the >>>>>> +# following error: >>>>>> +# Failed loading >>>>>> /usr/lib/php7/extensions/no-debug-non-zts-20190902/opcache.so: >>>>>> /usr/lib/php7/extensions/no-debug-non-zts-20190902/opcache.so: undefined >>>>>> symbol: shm_unlink >>>>>> +LDFLAGS += "${@ " -lrt " if bb.utils.contains('PACKAGECONFIG', >>>>>> 'opcache', 'true', 'false', d) else "" }" >>>>> >>>>> Is this actually a bug in 0001-opcache-config.m4-enable-opcache.patch >>>>> and should instead be fixed there? >>>> >>>> Yes, that does indeed fix the problem. Would you like me to reply to >>>> this thread with a new patch, or create a different thread? >>>> ... >>> >>> Your original patch is already in master, please submit a new patch in a >>> different thread that removes this workaround from php_7.4.4.bb and >>> fixes 0001-opcache-config.m4-enable-opcache.patch. >>> >>> Thanks >>> Adrian >>> >>> >>> >>> >> >> >>
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#84289): https://lists.openembedded.org/g/openembedded-devel/message/84289 Mute This Topic: https://lists.openembedded.org/mt/74056955/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
