On Fri, Jun 12, 2020 at 1:01 PM Fagundes, Paulo <paulohefagun...@gmail.com> wrote:
> this is only my second upstream patch to this project, so I'm still > learning about email patches and about the standards. I'm not sure if it's > ok to add multiple recipes to a single commit, but I added these because I > added fastapi and uvicorn to our project and all of these dependencies were > needed. > It’s very hard to review multiple additions in one email. Instead, stage the dependencies first (each as a separate commit) and then add the depending recipe. This also makes handling patch review changes much easier, as each new recipe becomes atomic. > another thing to note is that some of my peers were having trouble > building uvloop. > I was able to build uvloop just fine on my Arch Linux system, but my peers > on Ubuntu 18.04 LTS got errors in the compile stage when uvloop tried to > call ./configure > > So if anyone can check that it works for them that would be great > > Let me know if this patch is ok and if we need to separate it into > different patches for each recipe let me know. Thanks > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#85097): https://lists.openembedded.org/g/openembedded-devel/message/85097 Mute This Topic: https://lists.openembedded.org/mt/74846738/21656 Group Owner: openembedded-devel+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
