Hi Paul, On Wed, 20 Jan 2021 at 11:23, Paul Barker <[email protected]> wrote: > > On Wed, 20 Jan 2021 at 09:18, Clément Péron <[email protected]> wrote: > > > > Add Google RE2 regular expression library. > > > > This is used in new version of gRPC. > > > > Signed-off-by: Clément Péron <[email protected]> > > --- > > > > Hi, > > > > This is my first contribution to meta-openembedded. > > > > I would like to bump gRPC to new version but re2 library is required. > > > > I'm not sure if i should call the package re2 or libre2. > > Hi Clément, > > I'd use "re2" if that's the upstream name of the project. > > You should also modify the commit summary to follow the format shown > in https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines. > So it'd be something like "re2: Add recipe for Google RE2 library".
Thanks for the review, I will send a v2, Regards, Clement > > Thanks, > > -- > Paul Barker > Konsulko Group
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#88899): https://lists.openembedded.org/g/openembedded-devel/message/88899 Mute This Topic: https://lists.openembedded.org/mt/79975084/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
