Hi,
is the
ALLOW_EMPTY_${PN}-nmcli*
actually useful for anything? Why should the empty package exist? If people
include it in the image, then they need to make sure the PACKAGECONFIG is
enabled.
And when it's not enabled do_rootfs will correctly fail. Creating useless
empty package hides this useful error which IMHO makes it worse.
Regards,
On Tue, Jan 26, 2021 at 12:57 PM Adrian Freihofer <
adrian.freiho...@gmail.com> wrote:
> Signed-off-by: Adrian Freihofer <adrian.freiho...@siemens.com>
> ---
> .../networkmanager/networkmanager_1.28.0.bb | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta-networking/recipes-connectivity/networkmanager/
> networkmanager_1.28.0.bb
> b/meta-networking/recipes-connectivity/networkmanager/
> networkmanager_1.28.0.bb
> index 1053bdd42..36d50668e 100644
> --- a/meta-networking/recipes-connectivity/networkmanager/
> networkmanager_1.28.0.bb
> +++ b/meta-networking/recipes-connectivity/networkmanager/
> networkmanager_1.28.0.bb
> @@ -62,7 +62,7 @@ do_compile_prepend() {
> export
> GIR_EXTRA_LIBS_PATH="${B}/libnm/.libs:${B}/libnm-glib/.libs:${B}/libnm-util/.libs"
> }
>
> -PACKAGECONFIG ??= "nss ifupdown dnsmasq \
> +PACKAGECONFIG ??= "nss ifupdown dnsmasq nmcli \
> ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd',
> bb.utils.contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d), d)} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez5', '',
> d)} \
> ${@bb.utils.filter('DISTRO_FEATURES', 'wifi polkit', d)} \
> @@ -85,6 +85,7 @@ PACKAGECONFIG[wifi] =
> "--enable-wifi=yes,--enable-wifi=no,,wpa-supplicant"
> PACKAGECONFIG[ifupdown] = "--enable-ifupdown,--disable-ifupdown"
> PACKAGECONFIG[qt4-x11-free] = "--enable-qt,--disable-qt,qt4-x11-free"
> PACKAGECONFIG[cloud-setup] =
> "--with-nm-cloud-setup=yes,--with-nm-cloud-setup=no"
> +PACKAGECONFIG[nmcli] = "--with-nmcli=yes,--with-nmcli=no,readline"
>
> PACKAGES =+ " \
> ${PN}-nmcli ${PN}-nmcli-doc \
> @@ -140,10 +141,12 @@ FILES_${PN}-dev += " \
> FILES_${PN}-nmcli = " \
> ${bindir}/nmcli \
> "
> +ALLOW_EMPTY_${PN}-nmcli = "1"
>
> FILES_${PN}-nmcli-doc = " \
> ${mandir}/man1/nmcli* \
> "
> +ALLOW_EMPTY_${PN}-nmcli-doc = "1"
>
> FILES_${PN}-nmtui = " \
> ${bindir}/nmtui \
> --
> 2.26.2
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#89083):
https://lists.openembedded.org/g/openembedded-devel/message/89083
Mute This Topic: https://lists.openembedded.org/mt/80141704/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
