On Saturday, 19 February 2022, 19:24:37 CET, Khem Raj wrote:
> On Sat, Feb 19, 2022 at 1:05 AM Clément Péron <peron.c...@gmail.com> wrote:
> >
> > Hi Christian,
> >
> > On Thu, 17 Feb 2022 at 15:45, Christian Eggers <cegg...@arri.de> wrote:
> > >
> > > "A multiplatform C++ library for capturing, parsing and crafting of
> > > network packets"
> > >
> > > PcapPlusPlus uses as custom build system (shell script + Makefile).
> > > There were attempts for using cmake but this work has never been
> > > finished.
> >
> > Work is still ongoing by me
> > (https://github.com/seladb/PcapPlusPlus/pull/652), Review and help is
> > welcome :)
> 
> this fails on riscv32 which has 64bit time_t on by default unlike
> older 32bit architectures
> see
> https://errors.yoctoproject.org/Errors/Details/629829/

I see the same problem locally on 32 bit ARM/musl, but only as a warning,
not as an error.

The C++ code converts from from struct timeval to struct timespec:
https://github.com/seladb/PcapPlusPlus/blob/master/Pcap%2B%2B/src/NetworkUtils.cpp#L172

struct timeval uses 'suseconds_t' for tv_usec which is _Int64 on musl, while
struct timespec uses 'long' for tv_nsec.

1. I think that conversion from useconds to nseconds requires multiplication 
with 1000.
2. Is there any problem casting from 'suseconds_t' to 'long'? I guess that 
nanoseconds
cannot exceed 32 bit.

> > > +
> > > +EXTRA_CONF:libc-musl += "--musl"
> > I think there is one fix required to build musl
> > https://github.com/seladb/PcapPlusPlus/commit/0607f5ccb7a26bc1567908507e46603e7c16b1ac
> >
> 
> additionally we should be using
> 
> EXTRA_CONF:append:libc-musl = " --musl"

From bitbake user manual:
> These operators differ from the ":=", ".=", "=.", "+=", and "=+" operators in 
> that their effects are applied at variable expansion time rather than being 
> immediately applied.

What is the reason for using override style here?

> > > +# main package is empty
> > > +RDEPENDS:${PN}-dev = ""
> >
> > Why not use ALLOW_EMPTY here ?
> 
> lesser of two evils.

RDEPENDS:${PN}-dev = "" is used several times in oe-core / meta-openembedded. 
Some
comments show that this is for the same reason (empty main package). Would it be
useful to covert some/all occurrences?







-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#95406): 
https://lists.openembedded.org/g/openembedded-devel/message/95406
Mute This Topic: https://lists.openembedded.org/mt/89210336/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to