Hi Michael
I have tried running git config --global sendemail.from and send you a new mail.
Could help me to check it?
Thanks
--------------------------------------------------
Zheng Ruoqin
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
ADDR.: No.6 Wenzhu Road, Software Avenue,
Nanjing, 210012, China
MAIL : zhengrq.f...@fujistu.com
> -----Original Message-----
> From: Michael Opdenacker <michael.opdenac...@bootlin.com>
> Sent: Tuesday, October 18, 2022 3:05 PM
> To: Zheng, Ruoqin/郑 若钦 <zhengrq.f...@fujitsu.com>
> Cc: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-python] [PATCH] python3-stevedore: upgrade 4.0.0 ->
> 4.0.1
>
> Hi Zheng
>
> Thank you for the patch!
>
> On 10/18/22 03:15, zhengruoqin wrote:
> > Signed-off-by: Zheng Ruoqin <zhengrq.f...@fujitsu.com>
> > ---
> > .../{python3-stevedore_4.0.0.bb => python3-stevedore_4.0.1.bb} | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > rename
> > meta-python/recipes-devtools/python/{python3-stevedore_4.0.0.bb =>
> > python3-stevedore_4.0.1.bb} (80%)
> >
> > diff --git
> > a/meta-python/recipes-devtools/python/python3-stevedore_4.0.0.bb
> > b/meta-python/recipes-devtools/python/python3-stevedore_4.0.1.bb
> > similarity index 80%
> > rename from
> > meta-python/recipes-devtools/python/python3-stevedore_4.0.0.bb
> > rename to
> > meta-python/recipes-devtools/python/python3-stevedore_4.0.1.bb
> > index 46c6d831aa..70c43f3ace 100644
> > --- a/meta-python/recipes-devtools/python/python3-stevedore_4.0.0.bb
> > +++ b/meta-python/recipes-devtools/python/python3-stevedore_4.0.1.bb
> > @@ -3,7 +3,7 @@ HOMEPAGE =
> "https://docs.openstack.org/stevedore/latest/";
> > LICENSE = "Apache-2.0"
> > LIC_FILES_CHKSUM =
> "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
> >
> > -SRC_URI[sha256sum] =
> "f82cc99a1ff552310d19c379827c2c64dd9f85a38bcd5559db2470161867b786"
> > +SRC_URI[sha256sum] =
> "9a23111a6e612270c591fd31ff3321c6b5f3d5f3dabb1427317a5ab608fc261a"
> >
> > DEPENDS += "${PYTHON_PN}-pbr-native"
> >
> There's a problem with the way you send your patches though.
>
> If I apply your patch through "git am", the author of the commit is:
>
> zhengrq.f...@fujitsu.com
>
> instead of
>
> Zheng Ruoqin <zhengrq.f...@fujitsu.com>
>
>
> Because of this issue, the maintainer has to manually fix this field when
> accepting your patch. Worse, if he doesn't catch this, that's harder to fix
> afterwards.
>
> You should be able to fix this by running:
>
> git config --global sendemail.from "zhengrq.f...@fujitsu.com"
> This should add a "From" field to the sent patch which "git am" should be able
> to match with your name.
>
> See
> https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbe
> dded#Sending_using_git-send-email
>
> Could you try to send an update? You could send it to me again through
> private-email first.
>
> Thanks in advance
> Michael.
>
> --
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#99236):
https://lists.openembedded.org/g/openembedded-devel/message/99236
Mute This Topic: https://lists.openembedded.org/mt/94399837/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
