On Thu, Dec 7, 2023 at 12:34 AM Petr Chernikov <p.cherni...@yadro.com> wrote:
> Good catch Raj! Thank you! > > > > I’ve tested mosh compilation and yes, this fails without some changes: > > > > I’ve added ` CXXFLAGS:append = " -std=c++17"` to mosh recipe and > compilation is fixed, so my question: > > Should I put both changes (for mosh and for abseil-cpp) in one patch? > Two patches in one series yes > > > > > Yours sincerely, > *Petr Chernikov* > > > > > > *From:* Khem Raj <raj.k...@gmail.com> > *Sent:* Wednesday, December 6, 2023 6:07 PM > *To:* Petr Chernikov <p.cherni...@yadro.com> > *Cc:* openembedded-devel@lists.openembedded.org > *Subject:* Re: [oe] [PATCH] abseil-cpp: remove -Dcmake_cxx_standard=14 > flag from extra_oecmake > > > > «Внимание! Данное письмо от внешнего адресата!» > > > > > > On Wed, Dec 6, 2023 at 3:01 AM Petr Chernikov <p.cherni...@yadro.com> > wrote: > > Raj, is my testing enough to apply changes? > > > > I think you have to compile mosh package to see the issue abseil builds > fine > > > > -----Original Message----- > From: Petr Chernikov > Sent: Tuesday, December 5, 2023 10:53 AM > To: 'Khem Raj' <raj.k...@gmail.com> > Cc: openembedded-devel@lists.openembedded.org > Subject: RE: [oe] [PATCH] abseil-cpp: remove -Dcmake_cxx_standard=14 flag > from extra_oecmake > > Hi Raj, > Thank you for feedback! > > I've just tested compilation via clang using meta-clang layer - this is > fine > > I've also tested `native` compilation using both gcc and clang, this is OK > too. > But I don't know how to test nativesdk, any thoughts about this kind of > compilation? > > > -----Original Message----- > From: Khem Raj <raj.k...@gmail.com> > Sent: Tuesday, December 5, 2023 1:46 AM > To: Petr Chernikov <p.cherni...@yadro.com> > Cc: openembedded-devel@lists.openembedded.org > Subject: Re: [oe] [PATCH] abseil-cpp: remove -Dcmake_cxx_standard=14 flag > from extra_oecmake > > «Внимание! Данное письмо от внешнего адресата!» > > here is a problem which might be related to this change > > https://errors.yoctoproject.org/Errors/Details/745165/ > > On Mon, Dec 4, 2023 at 7:22 AM Khem Raj <raj.k...@gmail.com> wrote: > > > > > > > > On Mon, Dec 4, 2023 at 6:23 AM Petr Chernikov <p.cherni...@yadro.com> > wrote: > >> > >> Old versions of abseil-cpp could not be compiled using C++ Standard 17. > >> For now this cmake flag is not needed. > > > > > > Can you check if this works with clang compiler as well > >> > >> > >> > >> Signed-off-by: Petr Chernikov <p.cherni...@yadro.com> > >> > >> diff --git a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb > b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb > >> index f847ebf15..4705b6f8c 100644 > >> --- a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb > >> +++ b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb > >> @@ -26,7 +26,6 @@ inherit cmake > >> > >> EXTRA_OECMAKE = "-DBUILD_SHARED_LIBS=ON \ > >> -DBUILD_TESTING=OFF \ > >> - -DCMAKE_CXX_STANDARD=14 \ > >> -DABSL_ENABLE_INSTALL=ON \ > >> " > >> > >> > >> > >> > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#107281): https://lists.openembedded.org/g/openembedded-devel/message/107281 Mute This Topic: https://lists.openembedded.org/mt/102970930/21656 Group Owner: openembedded-devel+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
